<p style="white-space: pre-wrap; word-wrap: break-word;">I know this is marked WIP (not sure if it will still be after this), but I figured I'd give this a look over anyhow.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13945">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13945/1/include/asterisk/res_pjsip_session_caps.h">File include/asterisk/res_pjsip_session_caps.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13945/1/include/asterisk/res_pjsip_session_caps.h@24">Patch Set #1, Line 24:</a> <code style="font-family:monospace,monospace">struct ast_sip_session_caps;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This appears to no longer be used and can be removed?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13945/1/res/res_pjsip_session/pjsip_session_caps.c">File res/res_pjsip_session/pjsip_session_caps.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13945/1/res/res_pjsip_session/pjsip_session_caps.c@35">Patch Set #1, Line 35:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">struct ast_sip_session_caps {<br> struct ast_format_cap *call_offer_cap;<br>};<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">No longer used and can be removed?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13945/1/res/res_pjsip_session/pjsip_session_caps.c@139">Patch Set #1, Line 139:</a> <code style="font-family:monospace,monospace">              session->endpoint->preferred_codec_only) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This needs to be moved out of this function. It only applies to incoming, and I think we want to make this and the new "incoming" option mutually exclusive (if one is set the other shouldn't be)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13945">change 13945</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13945"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id4ec0b4a906c2ae5885bf947f101c59059935437 </div>
<div style="display:none"> Gerrit-Change-Number: 13945 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-CC: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Mar 2020 23:28:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>