<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13838">View Change</a></p><div style="white-space:pre-wrap">Approvals:
George Joseph: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">message & stasis/messaging: make text message variables work in ARI<br><br>When a text message was received any associated variable was not written to<br>the ARI TextMessageReceived event. This occurred because Asterisk only wrote<br>out "send" variables. However, even those "send" variables would fail ARI<br>validation due to a TextMessageVariable formatting bug.<br><br>Since it seems the TextMessageReceived event has never been able to include<br>actual variables it was decided to remove the TextMessageVariable object type<br>from ARI, and simply return a JSON object of key/value pairs for variables.<br>This aligns more with how the ARI sendMessage handles variables, and other<br>places in ARI.<br><br>That being the case, and since this is technically an API breaking change (no<br>one should really be affected since things never really worked) the ARI version<br>was updated to reflect that.<br><br>ASTERISK-28755 #close<br><br>Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f<br>---<br>A doc/UPGRADE-staging/ari_messaging.txt<br>M include/asterisk/message.h<br>M main/message.c<br>M res/ari/ari_model_validators.c<br>M res/ari/ari_model_validators.h<br>M res/stasis/messaging.c<br>M rest-api/api-docs/endpoints.json<br>M rest-api/resources.json<br>8 files changed, 66 insertions(+), 109 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/UPGRADE-staging/ari_messaging.txt b/doc/UPGRADE-staging/ari_messaging.txt</span><br><span>new file mode 100644</span><br><span>index 0000000..199a8a2</span><br><span>--- /dev/null</span><br><span>+++ b/doc/UPGRADE-staging/ari_messaging.txt</span><br><span>@@ -0,0 +1,26 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: ARI</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: res_stasis</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+The "TextMessageReceived" event used to include a list of "TextMessageVariable"</span><br><span style="color: hsl(120, 100%, 40%);">+objects as part of its output. Due to a couple of bugs in Asterisk a list of</span><br><span style="color: hsl(120, 100%, 40%);">+received variables was never included even if ones were available. However,</span><br><span style="color: hsl(120, 100%, 40%);">+variables set to send would be (which they should have not been), but would</span><br><span style="color: hsl(120, 100%, 40%);">+fail validation due to the bad formatting.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+So basically there was no way to get a "TextMessageReceived" event with</span><br><span style="color: hsl(120, 100%, 40%);">+variables. Due to this the API has changed. The "TextMessageVariable" object</span><br><span style="color: hsl(120, 100%, 40%);">+no longer exists. "TextMessageReceived" now returns a JSON object of key/value</span><br><span style="color: hsl(120, 100%, 40%);">+pairs. So for instance instead of a list of "TextMessageVariable" objects:</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+[ TextMessageVariable, TextMessageVariable, TextMessageVariable]</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+where a TextMessageVariable was supposed to be:</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+{ "key": "<var name>", "value":, "<var value>" }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+The output is now just:</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+{ "<var name>": "<var value>" }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+This aligns more with how variables are specified when sending a message, as</span><br><span style="color: hsl(120, 100%, 40%);">+well as other variable lists in ARI.</span><br><span>diff --git a/include/asterisk/message.h b/include/asterisk/message.h</span><br><span>index 826fa0a..f5b7a75 100644</span><br><span>--- a/include/asterisk/message.h</span><br><span>+++ b/include/asterisk/message.h</span><br><span>@@ -397,6 +397,19 @@</span><br><span> int ast_msg_var_iterator_next(const struct ast_msg *msg, struct ast_msg_var_iterator *iter, const char **name, const char **value);</span><br><span> </span><br><span> /*!</span><br><span style="color: hsl(120, 100%, 40%);">+ * \brief Get the next variable name and value that was set on a received message</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param msg The message with the variables</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param iter An iterator created with ast_msg_var_iterator_init</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param name A pointer to the name result pointer</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param value A pointer to the value result pointer</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval 0 No more entries</span><br><span style="color: hsl(120, 100%, 40%);">+ * \retval 1 Valid entry</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+int ast_msg_var_iterator_next_received(const struct ast_msg *msg,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ast_msg_var_iterator *iter, const char **name, const char **value);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*!</span><br><span> * \brief Destroy a message variable iterator</span><br><span> * \param iter Iterator to be destroyed</span><br><span> */</span><br><span>diff --git a/main/message.c b/main/message.c</span><br><span>index 0543bf4..128f4d9 100644</span><br><span>--- a/main/message.c</span><br><span>+++ b/main/message.c</span><br><span>@@ -629,7 +629,9 @@</span><br><span> return iter;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int ast_msg_var_iterator_next(const struct ast_msg *msg, struct ast_msg_var_iterator *iter, const char **name, const char **value)</span><br><span style="color: hsl(120, 100%, 40%);">+static int ast_msg_var_iterator_get_next(const struct ast_msg *msg,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ast_msg_var_iterator *iter, const char **name, const char **value,</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int send)</span><br><span> {</span><br><span> struct msg_data *data;</span><br><span> </span><br><span>@@ -637,8 +639,8 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Skip any that aren't marked for sending out */</span><br><span style="color: hsl(0, 100%, 40%);">- while ((data = ao2_iterator_next(&iter->iter)) && !data->send) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Skip any that we're told to */</span><br><span style="color: hsl(120, 100%, 40%);">+ while ((data = ao2_iterator_next(&iter->iter)) && (data->send != send)) {</span><br><span> ao2_ref(data, -1);</span><br><span> }</span><br><span> </span><br><span>@@ -646,7 +648,7 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (data->send) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (data->send == send) {</span><br><span> *name = data->name;</span><br><span> *value = data->value;</span><br><span> }</span><br><span>@@ -658,6 +660,17 @@</span><br><span> return 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+int ast_msg_var_iterator_next(const struct ast_msg *msg, struct ast_msg_var_iterator *iter, const char **name, const char **value)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return ast_msg_var_iterator_get_next(msg, iter, name, value, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int ast_msg_var_iterator_next_received(const struct ast_msg *msg,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ast_msg_var_iterator *iter, const char **name, const char **value)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return ast_msg_var_iterator_get_next(msg, iter, name, value, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void ast_msg_var_unref_current(struct ast_msg_var_iterator *iter)</span><br><span> {</span><br><span> ao2_cleanup(iter->current_used);</span><br><span>diff --git a/res/ari/ari_model_validators.c b/res/ari/ari_model_validators.c</span><br><span>index 8e23d6b..75bd983 100644</span><br><span>--- a/res/ari/ari_model_validators.c</span><br><span>+++ b/res/ari/ari_model_validators.c</span><br><span>@@ -941,9 +941,8 @@</span><br><span> } else</span><br><span> if (strcmp("variables", ast_json_object_iter_key(iter)) == 0) {</span><br><span> int prop_is_valid;</span><br><span style="color: hsl(0, 100%, 40%);">- prop_is_valid = ast_ari_validate_list(</span><br><span style="color: hsl(0, 100%, 40%);">- ast_json_object_iter_value(iter),</span><br><span style="color: hsl(0, 100%, 40%);">- ast_ari_validate_text_message_variable);</span><br><span style="color: hsl(120, 100%, 40%);">+ prop_is_valid = ast_ari_validate_object(</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_json_object_iter_value(iter));</span><br><span> if (!prop_is_valid) {</span><br><span> ast_log(LOG_ERROR, "ARI TextMessage field variables failed validation\n");</span><br><span> res = 0;</span><br><span>@@ -980,60 +979,6 @@</span><br><span> return ast_ari_validate_text_message;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int ast_ari_validate_text_message_variable(struct ast_json *json)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- int res = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- struct ast_json_iter *iter;</span><br><span style="color: hsl(0, 100%, 40%);">- int has_key = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- int has_value = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for (iter = ast_json_object_iter(json); iter; iter = ast_json_object_iter_next(json, iter)) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (strcmp("key", ast_json_object_iter_key(iter)) == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- int prop_is_valid;</span><br><span style="color: hsl(0, 100%, 40%);">- has_key = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- prop_is_valid = ast_ari_validate_string(</span><br><span style="color: hsl(0, 100%, 40%);">- ast_json_object_iter_value(iter));</span><br><span style="color: hsl(0, 100%, 40%);">- if (!prop_is_valid) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_log(LOG_ERROR, "ARI TextMessageVariable field key failed validation\n");</span><br><span style="color: hsl(0, 100%, 40%);">- res = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } else</span><br><span style="color: hsl(0, 100%, 40%);">- if (strcmp("value", ast_json_object_iter_key(iter)) == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- int prop_is_valid;</span><br><span style="color: hsl(0, 100%, 40%);">- has_value = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- prop_is_valid = ast_ari_validate_string(</span><br><span style="color: hsl(0, 100%, 40%);">- ast_json_object_iter_value(iter));</span><br><span style="color: hsl(0, 100%, 40%);">- if (!prop_is_valid) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_log(LOG_ERROR, "ARI TextMessageVariable field value failed validation\n");</span><br><span style="color: hsl(0, 100%, 40%);">- res = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } else</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_log(LOG_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">- "ARI TextMessageVariable has undocumented field %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- ast_json_object_iter_key(iter));</span><br><span style="color: hsl(0, 100%, 40%);">- res = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!has_key) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_log(LOG_ERROR, "ARI TextMessageVariable missing required field key\n");</span><br><span style="color: hsl(0, 100%, 40%);">- res = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!has_value) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_log(LOG_ERROR, "ARI TextMessageVariable missing required field value\n");</span><br><span style="color: hsl(0, 100%, 40%);">- res = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return res;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-ari_validator ast_ari_validate_text_message_variable_fn(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return ast_ari_validate_text_message_variable;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> int ast_ari_validate_caller_id(struct ast_json *json)</span><br><span> {</span><br><span> int res = 1;</span><br><span>diff --git a/res/ari/ari_model_validators.h b/res/ari/ari_model_validators.h</span><br><span>index 64e11c0..a8b24ba 100644</span><br><span>--- a/res/ari/ari_model_validators.h</span><br><span>+++ b/res/ari/ari_model_validators.h</span><br><span>@@ -389,24 +389,6 @@</span><br><span> ari_validator ast_ari_validate_text_message_fn(void);</span><br><span> </span><br><span> /*!</span><br><span style="color: hsl(0, 100%, 40%);">- * \brief Validator for TextMessageVariable.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * A key/value pair variable in a text message.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * \param json JSON object to validate.</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns True (non-zero) if valid.</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns False (zero) if invalid.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-int ast_ari_validate_text_message_variable(struct ast_json *json);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*!</span><br><span style="color: hsl(0, 100%, 40%);">- * \brief Function pointer to ast_ari_validate_text_message_variable().</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * See \ref ast_ari_model_validators.h for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-ari_validator ast_ari_validate_text_message_variable_fn(void);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*!</span><br><span> * \brief Validator for CallerID.</span><br><span> *</span><br><span> * Caller identification</span><br><span>@@ -1480,10 +1462,7 @@</span><br><span> * - body: string (required)</span><br><span> * - from: string (required)</span><br><span> * - to: string (required)</span><br><span style="color: hsl(0, 100%, 40%);">- * - variables: List[TextMessageVariable]</span><br><span style="color: hsl(0, 100%, 40%);">- * TextMessageVariable</span><br><span style="color: hsl(0, 100%, 40%);">- * - key: string (required)</span><br><span style="color: hsl(0, 100%, 40%);">- * - value: string (required)</span><br><span style="color: hsl(120, 100%, 40%);">+ * - variables: object</span><br><span> * CallerID</span><br><span> * - name: string (required)</span><br><span> * - number: string (required)</span><br><span>diff --git a/res/stasis/messaging.c b/res/stasis/messaging.c</span><br><span>index 4a86d58..4df10cc 100644</span><br><span>--- a/res/stasis/messaging.c</span><br><span>+++ b/res/stasis/messaging.c</span><br><span>@@ -264,23 +264,20 @@</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- json_vars = ast_json_array_create();</span><br><span style="color: hsl(120, 100%, 40%);">+ json_vars = ast_json_object_create();</span><br><span> if (!json_vars) {</span><br><span> ast_msg_var_iterator_destroy(it_vars);</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- while (ast_msg_var_iterator_next(msg, it_vars, &name, &value)) {</span><br><span style="color: hsl(0, 100%, 40%);">- struct ast_json *json_tuple;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- json_tuple = ast_json_pack("{s: s}", name, value);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!json_tuple) {</span><br><span style="color: hsl(120, 100%, 40%);">+ while (ast_msg_var_iterator_next_received(msg, it_vars, &name, &value)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ast_json *json_val = ast_json_string_create(value);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!json_val || ast_json_object_set(json_vars, name, json_val)) {</span><br><span> ast_json_unref(json_vars);</span><br><span> ast_msg_var_iterator_destroy(it_vars);</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_json_array_append(json_vars, json_tuple);</span><br><span> ast_msg_var_unref_current(it_vars);</span><br><span> }</span><br><span> ast_msg_var_iterator_destroy(it_vars);</span><br><span>diff --git a/rest-api/api-docs/endpoints.json b/rest-api/api-docs/endpoints.json</span><br><span>index 13a5bed..6515295 100644</span><br><span>--- a/rest-api/api-docs/endpoints.json</span><br><span>+++ b/rest-api/api-docs/endpoints.json</span><br><span>@@ -233,22 +233,6 @@</span><br><span> }</span><br><span> }</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- "TextMessageVariable": {</span><br><span style="color: hsl(0, 100%, 40%);">- "id": "TextMessageVariable",</span><br><span style="color: hsl(0, 100%, 40%);">- "description": "A key/value pair variable in a text message.",</span><br><span style="color: hsl(0, 100%, 40%);">- "properties": {</span><br><span style="color: hsl(0, 100%, 40%);">- "key": {</span><br><span style="color: hsl(0, 100%, 40%);">- "type": "string",</span><br><span style="color: hsl(0, 100%, 40%);">- "description": "A unique key identifying the variable.",</span><br><span style="color: hsl(0, 100%, 40%);">- "required": true</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span style="color: hsl(0, 100%, 40%);">- "value": {</span><br><span style="color: hsl(0, 100%, 40%);">- "type": "string",</span><br><span style="color: hsl(0, 100%, 40%);">- "description": "The value of the variable.",</span><br><span style="color: hsl(0, 100%, 40%);">- "required": true</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span> "TextMessage": {</span><br><span> "id": "TextMessage",</span><br><span> "description": "A text message.",</span><br><span>@@ -269,8 +253,8 @@</span><br><span> "required": true</span><br><span> },</span><br><span> "variables": {</span><br><span style="color: hsl(0, 100%, 40%);">- "type": "List[TextMessageVariable]",</span><br><span style="color: hsl(0, 100%, 40%);">- "description": "Technology specific key/value pairs associated with the message.",</span><br><span style="color: hsl(120, 100%, 40%);">+ "type": "object",</span><br><span style="color: hsl(120, 100%, 40%);">+ "description": "Technology specific key/value pairs (JSON object) associated with the message.",</span><br><span> "required": false</span><br><span> }</span><br><span> }</span><br><span>diff --git a/rest-api/resources.json b/rest-api/resources.json</span><br><span>index 20d58f9..63dbe9b 100644</span><br><span>--- a/rest-api/resources.json</span><br><span>+++ b/rest-api/resources.json</span><br><span>@@ -2,7 +2,7 @@</span><br><span> "_copyright": "Copyright (C) 2012 - 2013, Digium, Inc.",</span><br><span> "_author": "David M. Lee, II <dlee@digium.com>",</span><br><span> "_svn_revision": "$Revision$",</span><br><span style="color: hsl(0, 100%, 40%);">- "apiVersion": "1.10.2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "apiVersion": "1.11.2",</span><br><span> "swaggerVersion": "1.1",</span><br><span> "basePath": "http://localhost:8088/ari",</span><br><span> "apis": [</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13838">change 13838</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13838"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f </div>
<div style="display:none"> Gerrit-Change-Number: 13838 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>