<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13803">View Change</a></p><p>15 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml">File tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml@63">Patch Set #7, Line 63:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  <!-- Packet lost can be simulated in any send/recv message by         --><br>  <!-- by adding the 'lost = "10"'. Value can be [1-100] percent.       --><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove this comment as you're not doing packet loss testing.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml@84">Patch Set #7, Line 84:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     <action><br>          <ereg regexp="a=sendonly" search_in="body" check_it="true" assign_to="9"/><br>              <ereg regexp="[[:punct:]](.*)[[:punct:]]" search_in="hdr" header="Contact:" check_it="true" assign_to="6,1" /><br>          <ereg regexp=".*" search_in="hdr" header="From:" check_it="true" assign_to="2" /><br>          <ereg regexp=".*" search_in="hdr" header="To:" check_it="true" assign_to="3" /><br>      </action><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fix mixing of tabs and spaces.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml@141">Patch Set #7, Line 141:</a> <code style="font-family:monospace,monospace">Content-Length: [len] </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob/extra space at EOL.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml@230">Patch Set #7, Line 230:</a> <code style="font-family:monospace,monospace"> <ereg regexp="a=sendonly" search_in="body" check_it="true" assign_to="11"/></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">tab vs space here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml@126">Patch Set #7, Line 126:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><pause milliseconds="500"/><br><br><send retrans="500"><br><![CDATA[<br><br>INVITE [$1] SIP/2.0<br>Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br>[last_Call-ID:]<br>From: [$3];tag=[call_number]<br>To: [$2]<br>CSeq: 2 INVITE<br>Contact: <sip:[local_ip]:[local_port]><br>Max-Forwards: 70<br>Content-Type: application/sdp<br>[routes]<br>Content-Length: [len] <br><br>v=0<br>o=HuaweiSoftX3000 6644052 6644052 IN IP[local_ip_type] [local_ip]<br>s=Sip Call<br>c=IN IP[media_ip_type] [media_ip]<br>t=0 0<br>m=audio [media_port] RTP/AVP 8 0 18 101<br>a=rtpmap:8 PCMA/8000<br>a=rtpmap:0 PCMU/8000<br>a=rtpmap:18 G729/8000<br>a=rtpmap:101 telephone-event/8000<br>a=fmtp:101 0-15<br>a=inactive<br><br>]]><br></send><br><br><recv response="100" optional="true"><br></recv><br><br><recv response="100" optional="true"><br></recv><br><br><recv response="200" rtd="true" crlf="true"><br><action><br>        <ereg regexp="a=inactive" search_in="body" check_it="true" assign_to="10"/><br></action><br></recv><br><Reference variables="10"/><br><br><br><send><br><![CDATA[<br><br>ACK [$1] SIP/2.0<br>Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br>[last_Call-ID:]<br>From: [$3];tag=[call_number]<br>To: [$2]<br>CSeq: 2 ACK<br>Max-Forwards: 70<br>Content-Length: 0<br>[routes]<br><br>]]><br></send><br><br><pause milliseconds="500"/><br><br><send retrans="500"><br><![CDATA[<br><br>INVITE [$1] SIP/2.0<br>Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br>[last_Call-ID:]<br>From: [$3];tag=[call_number]<br>To: [$2]<br>CSeq: 3 INVITE<br>Contact: <sip:[local_ip]:[local_port]><br>Max-Forwards: 70<br>Content-Type: application/sdp<br>[routes]<br>Content-Length: [len]<br><br>v=0<br>o=HuaweiSoftX3000 6644052 6644052 IN IP[local_ip_type] [local_ip]<br>s=Sip Call<br>c=IN IP[media_ip_type] [media_ip]<br>t=0 0<br>m=audio [media_port] RTP/AVP 8 0 18 101<br>a=rtpmap:8 PCMA/8000<br>a=rtpmap:0 PCMU/8000<br>a=rtpmap:18 G729/8000<br>a=rtpmap:101 telephone-event/8000<br>a=fmtp:101 0-15<br>a=recvonly<br><br>]]><br></send><br><br><recv response="100" optional="true"><br></recv><br><br><recv response="100" optional="true"><br></recv><br><br><recv response="200" rtd="true" crlf="true"><br><action><br>        <ereg regexp="a=sendonly" search_in="body" check_it="true" assign_to="11"/><br></action><br></recv><br><Reference variables="11"/><br><br><br><send><br><![CDATA[<br><br>ACK [$1] SIP/2.0<br>Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br>[last_Call-ID:]<br>From: [$3];tag=[call_number]<br>To: [$2]<br>CSeq: 3 ACK<br>Max-Forwards: 70<br>Content-Length: 0<br>[routes]<br><br>]]><br></send><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Indention this section to align with the others before/after it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uac_cluster_hold_reinvite.xml@279">Patch Set #7, Line 279:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  <!-- definition of the response time repartition table (unit is ms)   --><br>  <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/><br><br>  <!-- definition of the call length repartition table (unit is ms)     --><br>  <CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should need these so can be removed.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml">File tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@11">Patch Set #7, Line 11:</a> <code style="font-family:monospace,monospace">        <log message="Log to avoid the problem of not using $6 [$6]"/></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">tab vs space. Actually here you can remove this log line and just use a Reference element</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@82">Patch Set #7, Line 82:</a> <code style="font-family:monospace,monospace">Content-Length: [len] </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob at EOL.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@108">Patch Set #7, Line 108:</a> <code style="font-family:monospace,monospace"> <ereg regexp="a=recvonly" search_in="body" check_it="true" assign_to="9"/></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">tab vs space</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@7">Patch Set #7, Line 7:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><action><br>    <ereg regexp="[[:punct:]](.*)[[:punct:]]" search_in="hdr" header="Contact:" check_it="true" assign_to="6,1" /><br>  <ereg regexp=".*" search_in="hdr" header="From:" check_it="true" assign_to="2" /><br>  <ereg regexp=".*" search_in="hdr" header="To:" check_it="true" assign_to="3" /><br> <log message="Log to avoid the problem of not using $6 [$6]"/><br><br></action><br><br></recv><br><br><br><br><send><br><![CDATA[<br><br>SIP/2.0 100 Trying<br>[last_Via:]<br>[last_Call-ID:]<br>[last_From:]<br>[last_To:]<br>[last_CSeq:]<br>Content-Length: 0<br><br>]]><br></send><br><br><send retrans="500"><br><![CDATA[<br><br>SIP/2.0 200 OK<br>[last_Via:]<br>[last_Call-ID:]<br>[last_From:]<br>[last_To:];tag=[call_number]<br>[last_CSeq:]<br>Contact: <sip:736596371553211257@[local_ip]:[local_port];user=phone><br>Content-Type: application/sdp<br>[last_Record-Route]<br>Content-Length: [len]<br><br>v=0<br>o=HuaweiSoftX3000 6644052 6644052 IN IP[local_ip_type] [local_ip]<br>s=Sip Call<br>c=IN IP[media_ip_type] [media_ip]<br>t=0 0<br>m=audio [media_port] RTP/AVP 8 0 18 101<br>a=rtpmap:8 PCMA/8000<br>a=rtpmap:0 PCMU/8000<br>a=rtpmap:18 G729/8000<br>a=rtpmap:101 telephone-event/8000<br>a=fmtp:101 0-15<br><br>]]><br></send><br><br><recv request="ACK"<br>      rtd="true"<br>      crlf="true"><br></recv><br><br><pause milliseconds="500"/><br><br><send retrans="500"><br><![CDATA[<br><br>INVITE [$1] SIP/2.0<br>Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br>[last_Call-ID:]<br>From: [$3];tag=[call_number]<br>To: [$2]<br>CSeq: 1 INVITE<br>Contact: <sip:[local_ip]:[local_port]><br>Max-Forwards: 70<br>Content-Type: application/sdp<br>[routes]<br>Content-Length: [len] <br><br>v=0<br>o=HuaweiSoftX3000 6644052 6644052 IN IP[local_ip_type] [local_ip]<br>s=Sip Call<br>c=IN IP[media_ip_type] 0.0.0.0<br>t=0 0<br>m=audio [media_port] RTP/AVP 8 0 18 101<br>a=rtpmap:8 PCMA/8000<br>a=rtpmap:0 PCMU/8000<br>a=rtpmap:18 G729/8000<br>a=rtpmap:101 telephone-event/8000<br>a=fmtp:101 0-15<br>a=sendonly<br><br>]]><br></send><br><br><recv response="100" optional="true"><br></recv><br><br><recv response="100" optional="true"><br></recv><br><br><recv response="200" rtd="true" crlf="true"><br><action><br>        <ereg regexp="a=recvonly" search_in="body" check_it="true" assign_to="9"/><br></action><br></recv><br><Reference variables="9"/><br><br><br><send><br><![CDATA[<br><br>ACK [$1] SIP/2.0<br>Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br>[last_Call-ID:]<br>From: [$3];tag=[call_number]<br>To: [$2]<br>CSeq: 1 ACK<br>Max-Forwards: 70<br>Content-Length: 0<br>[routes]<br><br>]]><br></send><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">indent and align formatting.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@131">Patch Set #7, Line 131:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     <action><br>          <ereg regexp="a=inactive" search_in="body" check_it="true" assign_to="10"/><br>   </action><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">tabs vs spaces</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@170">Patch Set #7, Line 170:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    <action><br>          <ereg regexp="a=recvonly" search_in="body" check_it="true" assign_to="11"/><br>   </action><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">tabs vs spaces</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@215">Patch Set #7, Line 215:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@210">Patch Set #7, Line 210:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><recv request="BYE"><br></recv><br><br> <send><br> <![CDATA[<br> <br>SIP/2.0 200 OK<br>[last_Via:]<br>[last_From:]<br>[last_To:]<br>[last_Call-ID:]<br>[last_CSeq:]<br>Content-Length: 0<br><br>]]><br></send><br><br><br><!-- Keep the call open for a while in case the 200 is lost to be     --><br><!-- able to retransmit it if we receive the BYE again.               --><br><pause milliseconds="4000"/><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">indent and align formatting.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13803/7/tests/channels/pjsip/moh_passthru_inactive/sipp/uas_hold_reinvite.xml@233">Patch Set #7, Line 233:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><!-- definition of the response time repartition table (unit is ms)   --><br><ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/><br><br><!-- definition of the call length repartition table (unit is ms)     --><br><CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove these.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/13803">change 13803</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/13803"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I8b22fe78f5cc02c2b0b888d51df296c4509b1563 </div>
<div style="display:none"> Gerrit-Change-Number: 13803 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 03 Mar 2020 21:10:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>