<p>Joshua Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13677">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_sip: Clarify in sample docs how directmediapermit/-acl should be used<br><br>It said "restrict [...] which peers should be able to pass [audio]<br>to each other".<br><br>However, these settings are not global (for which you would expect<br>signaling IPs to be checked). These settings are available per peer<br>only, and the IPs being checked, are the RTP IPs.<br><br>Change-Id: I2a6c6cd7c2f5f30d1df4844e3e0308a077021660<br>---<br>M configs/samples/sip.conf.sample<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configs/samples/sip.conf.sample b/configs/samples/sip.conf.sample</span><br><span>index 7971b64..4947754 100644</span><br><span>--- a/configs/samples/sip.conf.sample</span><br><span>+++ b/configs/samples/sip.conf.sample</span><br><span>@@ -1059,7 +1059,9 @@</span><br><span>                                 ; the device is actually behind NAT.</span><br><span> </span><br><span> ;directmediadeny=0.0.0.0/0      ; Use directmediapermit and directmediadeny to restrict</span><br><span style="color: hsl(0, 100%, 40%);">-;directmediapermit=172.16.0.0/16; which peers should be able to pass directmedia to each other</span><br><span style="color: hsl(120, 100%, 40%);">+;directmediapermit=172.16.0.0/16; which RTP source IPs should be able to pass directmedia to</span><br><span style="color: hsl(120, 100%, 40%);">+                                ; each other. Note that directmedia ACLs are not a global</span><br><span style="color: hsl(120, 100%, 40%);">+                                ; setting, but must be defined per peer.</span><br><span>                                 ; (There is no default setting, this is just an example)</span><br><span>                                 ; Use this if some of your phones are on IP addresses that</span><br><span>                                 ; can not reach each other directly. This way you can force</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13677">change 13677</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13677"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2a6c6cd7c2f5f30d1df4844e3e0308a077021660 </div>
<div style="display:none"> Gerrit-Change-Number: 13677 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>