<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13597">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13597/2/main/pbx.c">File main/pbx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13597/2/main/pbx.c@4597">Patch Set #2, Line 4597:</a> <code style="font-family:monospace,monospace">(uint64_t) (sys_info.freeram + sys_info.bufferram)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you should put parentheses around this piece to ensure that the multiplication is done as a uint64_t and not casting the result of the entire computation after it has lost bits due to overflow.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Though you could avoid the need to cast entirely with explicit control over when operations are done by doing it this way:</p><p style="white-space: pre-wrap; word-wrap: break-word;">curfreemem = sys_info.freeram + sys_info.bufferram;<br>curfreemem *= sys_info.mem_unit;<br>curfreemem /= 1024 * 1024;</p><p style="white-space: pre-wrap; word-wrap: break-word;">Should also add a note that the calculation was done this way to avoid overflow problems.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13597">change 13597</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13597"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ief098bb6eb77378daeace8f97ba30701c8de55b8 </div>
<div style="display:none"> Gerrit-Change-Number: 13597 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Jan 2020 17:55:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>