<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13625">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Kevin Harwell: Looks good to me, but someone else must approve
Benjamin Keith Ford: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_queue: Deprecate the QueueMemberPause.Reason field<br><br>The QueueMemberPause AMI event includes two fields that return the<br>reason a member was paused.<br><br>* In release branches, deprecate Reason in favor of PausedReason.<br>* In master, remove the Reason field entirely.<br><br>ASTERISK-28349 #close<br>Reported by: Niksa Baldun<br><br>Change-Id: I01da58f2b0ab927baeee754870f62b51b7b3d296<br>---<br>M apps/app_queue.c<br>A doc/UPGRADE-staging/app_queue_remove_reason.txt<br>2 files changed, 7 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_queue.c b/apps/app_queue.c</span><br><span>index a0cb1f7..8cb3e32 100644</span><br><span>--- a/apps/app_queue.c</span><br><span>+++ b/apps/app_queue.c</span><br><span>@@ -1145,9 +1145,6 @@</span><br><span> <synopsis>Raised when a member is paused/unpaused in the queue.</synopsis></span><br><span> <syntax></span><br><span> <xi:include xpointer="xpointer(/docs/managerEvent[@name='QueueMemberStatus']/managerEventInstance/syntax/parameter)" /></span><br><span style="color: hsl(0, 100%, 40%);">- <parameter name="Reason"></span><br><span style="color: hsl(0, 100%, 40%);">- <para>The reason a member was paused.</para></span><br><span style="color: hsl(0, 100%, 40%);">- </parameter></span><br><span> </syntax></span><br><span> <see-also></span><br><span> <ref type="application">PauseQueueMember</ref></span><br><span>@@ -7448,7 +7445,7 @@</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int publish_queue_member_pause(struct call_queue *q, struct member *member, const char *reason)</span><br><span style="color: hsl(120, 100%, 40%);">+static int publish_queue_member_pause(struct call_queue *q, struct member *member)</span><br><span> {</span><br><span> struct ast_json *json_blob = queue_member_blob_create(q, member);</span><br><span> </span><br><span>@@ -7456,10 +7453,6 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!ast_strlen_zero(reason)) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_json_object_set(json_blob, "Reason", ast_json_string_create(reason));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> queue_publish_member_blob(queue_member_pause_type(), json_blob);</span><br><span> </span><br><span> return 0;</span><br><span>@@ -7520,7 +7513,7 @@</span><br><span> ast_queue_log(q->name, "NONE", mem->membername, (paused ? "PAUSE" : "UNPAUSE"),</span><br><span> "%s", S_OR(reason, ""));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- publish_queue_member_pause(q, mem, reason);</span><br><span style="color: hsl(120, 100%, 40%);">+ publish_queue_member_pause(q, mem);</span><br><span> }</span><br><span> </span><br><span> static int set_member_paused(const char *queuename, const char *interface, const char *reason, int paused)</span><br><span>diff --git a/doc/UPGRADE-staging/app_queue_remove_reason.txt b/doc/UPGRADE-staging/app_queue_remove_reason.txt</span><br><span>new file mode 100644</span><br><span>index 0000000..e333e2c</span><br><span>--- /dev/null</span><br><span>+++ b/doc/UPGRADE-staging/app_queue_remove_reason.txt</span><br><span>@@ -0,0 +1,5 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: app_queue</span><br><span style="color: hsl(120, 100%, 40%);">+Master-Only: True</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+The 'Reason' header in the QueueMemberPause AMI Event has been</span><br><span style="color: hsl(120, 100%, 40%);">+removed. The 'PausedReason' header should be used instead.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13625">change 13625</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13625"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I01da58f2b0ab927baeee754870f62b51b7b3d296 </div>
<div style="display:none"> Gerrit-Change-Number: 13625 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>