<p><a href="https://gerrit.asterisk.org/c/asterisk/+/13507">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13507/1/main/stasis.c">File main/stasis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13507/1/main/stasis.c@1858">Patch Set #1, Line 1858:</a> <code style="font-family:monospace,monospace">       char *temp_topic_name = ast_strdupa(topic_name);</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">You aren't modifying topic_name, why is the strdupa necessary?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah I was going to modify it then changed my mind and forgot to remove the strdupa.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13507/1/main/stasis.c@1859">Patch Set #1, Line 1859:</a> <code style="font-family:monospace,monospace">   int pool_topic_name_len = strlen(stasis_topic_name(pool->pool_topic)); /* Safe */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">What does 'Safe' mean here? That stasis_topic_name() will not return NULL?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">and that it will always return an NULL terminated string so there's no chance of an overflow.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13507">change 13507</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13507"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: I4396aa69dd83e4ab84c5b91b39293cfdbcf483e6 </div>
<div style="display:none"> Gerrit-Change-Number: 13507 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Jan 2020 14:16:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>