<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13505">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13505/1/channels/sig_pri.c">File channels/sig_pri.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13505/1/channels/sig_pri.c@1407">Patch Set #1, Line 1407:</a> <code style="font-family:monospace,monospace">               ast_set_hangupsource(owner, ast_channel_name(owner), 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You cannot call ast_set_hangupsource() with the channel lock held because it needs to get the channel's bridge lock.  To fix, you need to revert the current changes in the patch.  Then unlock and re-lock the pri->lock as below.</p><p style="white-space: pre-wrap; word-wrap: break-word;">sig_pri_unlock_private(pri->pvts[chanpos]);<br>ast_mutex_unlock(&pri->lock);<br>ast_set_hangup_source(owner, ast_channel_name(owner), 0);<br>ast_mutex_loc(&pri->lock);<br>sig_pri_lock_private(pri->pvts[chanpos]);</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also you'll need to update the commit message to reflect the change. 😊</p><p style="white-space: pre-wrap; word-wrap: break-word;">I keep forgetting that sig_pri_lock_owner() also releases the pri->lock to avoid deadlock.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13505">change 13505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13505"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Id74aaa5d4e3746063dbe9deed188eb65193cb9c9 </div>
<div style="display:none"> Gerrit-Change-Number: 13505 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Jan 2020 20:51:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>