<p>Joshua Colp has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13506">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_dial: Allow empty Dial targets.<br><br>This change makes it so that the following no longer<br>results in Dial failing:<br><br>Dial(PJSIP/1000&)<br>Dial(&PJSIP/1000)<br><br>As long as a single dial target is provided any<br>subsequent empty ones are not treated as fatal.<br><br>ASTERISK-28638<br><br>Change-Id: I641320a501aaf7429d0091d668a28cd99f445b85<br>---<br>M apps/app_dial.c<br>1 file changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/06/13506/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_dial.c b/apps/app_dial.c</span><br><span>index 77b3ace..5b13795 100644</span><br><span>--- a/apps/app_dial.c</span><br><span>+++ b/apps/app_dial.c</span><br><span>@@ -2254,7 +2254,7 @@</span><br><span>       );</span><br><span>   struct ast_flags64 opts = { 0, };</span><br><span>    char *opt_args[OPT_ARG_ARRAY_SIZE];</span><br><span style="color: hsl(0, 100%, 40%);">-     int fulldial = 0, num_dialed = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int fulldial = 0, num_dialed = 0, num_invalid = 0;</span><br><span>   int ignore_cc = 0;</span><br><span>   char device_name[AST_CHANNEL_NAME];</span><br><span>  char forced_clid_name[AST_MAX_EXTENSION];</span><br><span>@@ -2530,8 +2530,8 @@</span><br><span> </span><br><span>                num_dialed++;</span><br><span>                if (ast_strlen_zero(number)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  ast_log(LOG_WARNING, "Dial argument takes format (technology/resource)\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                   goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+                     num_invalid++;</span><br><span style="color: hsl(120, 100%, 40%);">+                        continue;</span><br><span>            }</span><br><span> </span><br><span>                tech_len = strlen(tech) + 1;</span><br><span>@@ -2804,6 +2804,12 @@</span><br><span> </span><br><span>    outgoing = AST_LIST_FIRST(&out_chans);</span><br><span>   if (!outgoing) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (num_invalid == num_dialed) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      ast_log(LOG_WARNING, "Dial argument takes format (technology/resource)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                 strcpy(pa.status, "INVALIDARGS");</span><br><span style="color: hsl(120, 100%, 40%);">+                   goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          strcpy(pa.status, "CHANUNAVAIL");</span><br><span>          if (fulldial == num_dialed) {</span><br><span>                        res = -1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13506">change 13506</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13506"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I641320a501aaf7429d0091d668a28cd99f445b85 </div>
<div style="display:none"> Gerrit-Change-Number: 13506 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>