<p>Joshua C. Colp <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13471">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Friendly Automation: Verified
  Joshua C. Colp: Looks good to me, approved; Approved for Submit
  Richard Mudgett: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.<br><br>Temporary channel lifespan is very short and CDR deactivation request<br>through ast_cdr_set_property() may happen when CDR is not available<br>yet. Use CDR_PROP() dialplan function instead, it will first wait<br>for pending CDR insertion requests to be processed.<br><br>ASTERISK-28636<br><br>Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074<br>---<br>M apps/app_chanisavail.c<br>1 file changed, 11 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_chanisavail.c b/apps/app_chanisavail.c</span><br><span>index 446bce1..1c7c1ec 100644</span><br><span>--- a/apps/app_chanisavail.c</span><br><span>+++ b/apps/app_chanisavail.c</span><br><span>@@ -134,6 +134,8 @@</span><br><span>     }</span><br><span>    peers = args.reqchans;</span><br><span>       if (peers) {</span><br><span style="color: hsl(120, 100%, 40%);">+          struct ast_custom_function *cdr_prop_func = ast_custom_function_find("CDR_PROP");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                cur = peers;</span><br><span>                 do {</span><br><span>                         /* remember where to start next time */</span><br><span>@@ -179,7 +181,9 @@</span><br><span>                                        ast_str_append(&tmp_availcause, 0, "%s%s", ast_str_strlen(tmp_availcause) ? "&" : "", tmp);</span><br><span> </span><br><span>                                        /* Disable CDR for this temporary channel. */</span><br><span style="color: hsl(0, 100%, 40%);">-                                   ast_cdr_set_property(ast_channel_name(tempchan), AST_CDR_FLAG_DISABLE_ALL);</span><br><span style="color: hsl(120, 100%, 40%);">+                                   if (cdr_prop_func) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                          ast_func_write(tempchan, "CDR_PROP(disable)", "1");</span><br><span style="color: hsl(120, 100%, 40%);">+                                       }</span><br><span> </span><br><span>                                        ast_hangup(tempchan);</span><br><span>                                        tempchan = NULL;</span><br><span>@@ -212,4 +216,9 @@</span><br><span>               AST_MODULE_LOAD_DECLINE : AST_MODULE_LOAD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-AST_MODULE_INFO_STANDARD_EXTENDED(ASTERISK_GPL_KEY, "Check channel availability");</span><br><span style="color: hsl(120, 100%, 40%);">+AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_DEFAULT, "Check channel availability",</span><br><span style="color: hsl(120, 100%, 40%);">+       .support_level = AST_MODULE_SUPPORT_EXTENDED,</span><br><span style="color: hsl(120, 100%, 40%);">+ .load = load_module,</span><br><span style="color: hsl(120, 100%, 40%);">+  .unload = unload_module,</span><br><span style="color: hsl(120, 100%, 40%);">+      .optional_modules = "func_cdr"</span><br><span style="color: hsl(120, 100%, 40%);">+);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13471">change 13471</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13471"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074 </div>
<div style="display:none"> Gerrit-Change-Number: 13471 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>