<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">Patch looks fine, just giving -1 so you notice the following:</p><p style="white-space: pre-wrap; word-wrap: break-word;">This feature needs a test. Should be possible to write one?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I gave that some thought originally and didn't really come up with a way to. It's all an internal implementation detail, so visibility into what has happened doesn't really exist. I'll give it some further thought though.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hrm yeah true. Thinking more I think a test for this would be challenging. This can go ahead and go in, and if for some reason you do think of a way to easily write a test it can always be added later.</p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4; color: #000000;">Code-Review +2</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13441">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13441">change 13441</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13441"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Idff80896ccfb8a58a816e4ce9ac4ebde785963ee </div>
<div style="display:none"> Gerrit-Change-Number: 13441 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua C. Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 19 Dec 2019 15:08:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>