<p><a href="https://gerrit.asterisk.org/c/asterisk/+/11579">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11579/32/apps/app_audiosocket.c">File apps/app_audiosocket.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/11579/32/apps/app_audiosocket.c@111">Patch Set #32, Line 111:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       if (ast_set_write_format(chan, ast_format_slin)) {<br>            ast_log(LOG_ERROR, "Failed to set write format to SLINEAR for channel %s\n", chanName);<br>             ao2_ref(writeFormat, -1);<br>             ao2_ref(readFormat, -1);<br>              return -1;<br>    }<br>     if (ast_set_read_format(chan, ast_format_slin)) {<br>             ast_log(LOG_ERROR, "Failed to set read format to SLINEAR for channel %s\n", chanName);<br><br>            /* Attempt to restore previous write format even though it is likely to<br>                * fail, since setting the read format did.<br>            */<br>           if (ast_set_write_format(chan, writeFormat)) {<br>                        ast_log(LOG_ERROR, "Failed to restore write format for channel %s\n", chanName);<br>            }<br>             ao2_ref(writeFormat, -1);<br>             ao2_ref(readFormat, -1);<br>              return -1;<br>    }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I ran a test to see, just sending a ulaw channel into this application, and it didn't look like ther […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">There should not be. Those just set up the translation path.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11579">change 11579</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11579"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5 </div>
<div style="display:none"> Gerrit-Change-Number: 11579 </div>
<div style="display:none"> Gerrit-PatchSet: 32 </div>
<div style="display:none"> Gerrit-Owner: Seán C. McCord <ulexus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Seán C. McCord <ulexus@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 Dec 2019 15:36:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>