<p><a href="https://gerrit.asterisk.org/c/asterisk/+/13310">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c">File apps/app_chanisavail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/2/apps/app_chanisavail.c@31">Patch Set #2, Line 31:</a> <code style="font-family:monospace,monospace"><depend>func_cdr</depend></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is not a "true" dependance, since app_chanisavail can work without it. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It should be declared as an optional dependency at the bottom of the source (replace the AST_MODULE_INFO_STANDARD_EXTENDED):</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_DEFAULT, "Check channel availability",<br>     .load = load_module,<br>  .unload = unload_module,<br>      .support_level = AST_MODULE_SUPPORT_EXTENDED,<br> .optional_modules = "func_cdr"<br>);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">This way `func_cdr` cannot be unloaded if app_chanisavail is loaded.. This prevents the rare possibility of a race between checking for CDR_PROP existing and using it.  This suggestion is for 16/17/master only, in Asterisk 13 module loader did not protect against this.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13310">change 13310</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13310"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074 </div>
<div style="display:none"> Gerrit-Change-Number: 13310 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-CC: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Dec 2019 22:57:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>