<p><a href="https://gerrit.asterisk.org/c/asterisk/+/13310">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/1/apps/app_chanisavail.c">File apps/app_chanisavail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13310/1/apps/app_chanisavail.c@182">Patch Set #1, Line 182:</a> <code style="font-family:monospace,monospace">                                       /* XXX Should this be conditioned to an option, due to performance cost? */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think this is the correct solution. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for the review, and for your suggestion about cdr_sync_message_type(): used with stasis_message_router_publish_sync() as in ast_cdr_engine_term(), I understand that it will enable indeed to wait for previous messages to be processed (not only, but including, the ast_channel_snapshot_type() that should make CDR available in active_cdrs_master container).</p><p style="white-space: pre-wrap; word-wrap: break-word;">But - maybe I am extrapolating too fast -, should it also apply to other functions looking for CDR in active_cdrs_master, and giving up if not found - with or without a log -, such as:</p><ul><li>ast_cdr_getvar(),</li><li>ast_cdr_serialize_variables(),</li><li>ast_cdr_setuserfield(),</li><li>ast_cdr_clear_property(),</li><li>ast_cdr_reset(),</li><li>ast_cdr_fork(),</li><li>cli_show_channel() (more uncertain about this one) ?</li><li>Or should this use of cdr_sync_message_type() even integrate directly cdr_object_get_by_name() ?</li></ul><p style="white-space: pre-wrap; word-wrap: break-word;">I hope I can run new tests and submit a new Patch Set before the end of the week.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13310">change 13310</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13310"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074 </div>
<div style="display:none"> Gerrit-Change-Number: 13310 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frederic LE FOLL <frederic.lefoll@c-s.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 02 Dec 2019 18:16:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>