<p style="white-space: pre-wrap; word-wrap: break-word;"><br>Hello Kevin,<br>Yeah we can apply the same logic for this side also. Actually we check for initiator because we only want to apply the logic on SDP answer if we receive a RE-INVITE, we want to try our best to honor the offer. <br>Thank you,<br>Salah</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13180">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c">File res/res_pjsip_t38.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c@705">Patch Set #1, Line 705:</a> <code style="font-family:monospace,monospace">                       if (session->t38state == T38_LOCAL_REINVITE) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Does initiator matter? It seems like we'd want to do the same for any negotiation scenario? Meaning  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">we check for initiator because we only want to apply the logic on SDP answer<br>if we receive an RE-INVITE, we want to try our best to honor the offer</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/2/res/res_pjsip_t38.c">File res/res_pjsip_t38.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/2/res/res_pjsip_t38.c@723">Patch Set #2, Line 723:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                     } else {<br>                              if (!pj_stricmp2(&attr->value, "t38UDPRedundancy")) {<br>                                        ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_REDUNDANCY);<br>                            } else if (!pj_stricmp2(&attr->value, "t38UDPFEC")) {<br>                                        ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_FEC);<br>                           } else {<br>                                      ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_NONE);<br>                          }<br>                     }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Wouldn't the same logic you added above apply if the incoming SDP is from the remote re-invite?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">we check for initiator because we only want to apply the logic on SDP answer<br>if we receive an RE-INVITE, we want to try our best to honor the offer</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13180">change 13180</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13180"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I343c62253ea4c8b7ee17abbfb377a4d484a14b19 </div>
<div style="display:none"> Gerrit-Change-Number: 13180 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Salah Ahmed <txrubel@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Nov 2019 00:37:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>