<p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure about this. Is there an RFC someplace, or a known convention as to the expectations for negotiation of the 't38faxudpec attribute?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Reasonably, it seems like if one side doesn't allow EC then EC would not be included, or processed. I'm not sure about the other two modes.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13180">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c">File res/res_pjsip_t38.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c@705">Patch Set #1, Line 705:</a> <code style="font-family:monospace,monospace">                     if (session->t38state == T38_LOCAL_REINVITE) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does initiator matter? It seems like we'd want to do the same for any negotiation scenario? Meaning if Asterisk is configured to not handle error correction then we'd want to make sure support for it was disabled for incoming or outgoing? Same for the other modes?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c@709">Patch Set #1, Line 709:</a> <code style="font-family:monospace,monospace">                                    } else if (!pj_stricmp2(&attr->value, "t38UDPRedundancy")) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If error correction is configured for FEC why potentially allow redundancy?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c@722">Patch Set #1, Line 722:</a> <code style="font-family:monospace,monospace">                                }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Spaces vs tabs issue here. Please use tabs.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13180">change 13180</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13180"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I343c62253ea4c8b7ee17abbfb377a4d484a14b19 </div>
<div style="display:none"> Gerrit-Change-Number: 13180 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Salah Ahmed <txrubel@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Nov 2019 00:11:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>