<p>Kevin Harwell has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13176">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bridge_softmix: clear hold when joining a softmix bridge<br><br>MOH continues to play if a channel was on hold prior to entering a softmix<br>bridge. When this happens other participants in the bridge will hear the<br>music, and it will not stop even if the original "holder" attempts an unhold.<br><br>For the most part a softmix bridge ignores holds, so a participating channel<br>shouldn't join while on hold. This patch checks to see if the channel joining<br>the softmix bridge is currently on hold. If so then it indicates an unhold.<br><br>ASTERISK-28618<br><br>Change-Id: I66ccd4efc80f5b4c3dd68186b379eb442916392b<br>---<br>M bridges/bridge_softmix.c<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/76/13176/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bridges/bridge_softmix.c b/bridges/bridge_softmix.c</span><br><span>index a90c716..d907084 100644</span><br><span>--- a/bridges/bridge_softmix.c</span><br><span>+++ b/bridges/bridge_softmix.c</span><br><span>@@ -726,6 +726,13 @@</span><br><span>                 sfu_topologies_on_join(bridge, bridge_channel);</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Complete any active hold before entering, or transitioning to softmix. */</span><br><span style="color: hsl(120, 100%, 40%);">+  if (ast_channel_hold_state(bridge_channel->chan) == AST_CONTROL_HOLD) {</span><br><span style="color: hsl(120, 100%, 40%);">+            ast_debug(1, "Channel %s simulating UNHOLD for bridge softmix join.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     ast_channel_name(bridge_channel->chan));</span><br><span style="color: hsl(120, 100%, 40%);">+           ast_indicate(bridge_channel->chan, AST_CONTROL_UNHOLD);</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  softmix_poke_thread(softmix_data);</span><br><span>   return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13176">change 13176</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13176"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I66ccd4efc80f5b4c3dd68186b379eb442916392b </div>
<div style="display:none"> Gerrit-Change-Number: 13176 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>