<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/apps/app_playback.c">File apps/app_playback.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/apps/app_playback.c@178">Patch Set #3, Line 178:</a> <code style="font-family:monospace,monospace">     char *lang, *x, *rule = NULL, *rule_head = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Multiple initializers on the same line.  Don't let Richard see this.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/apps/app_voicemail.c@1878">Patch Set #3, Line 1878:</a> <code style="font-family:monospace,monospace">                                        char *value = NULL, *new = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Multiple initializers on same line.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/apps/app_voicemail.c@1886">Patch Set #3, Line 1886:</a> <code style="font-family:monospace,monospace">                                               sprintf(new, "%s", newpassword);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need spaces around +1</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/channels/chan_motif.c">File channels/chan_motif.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/channels/chan_motif.c@2095">Patch Set #3, Line 2095:</a> <code style="font-family:monospace,monospace">              char *id = iks_find_attrib(codec, "id"), *attr_name = iks_find_attrib(codec, "name");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Multiple initializers.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/main/asterisk.c">File main/asterisk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/main/asterisk.c@4041">Patch Set #3, Line 4041:</a> <code style="font-family:monospace,monospace">        asterisk_daemon(isroot, runuser, rungroup);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is it possible that runuser and rungroup could be freed by RAII_VAR before the forked process can use it?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/res/res_pjsip/config_system.c">File res/res_pjsip/config_system.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13102/3/res/res_pjsip/config_system.c@86">Patch Set #3, Line 86:</a> <code style="font-family:monospace,monospace">sorcery</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we not actually use this in the function?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13102">change 13102</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13102"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25 </div>
<div style="display:none"> Gerrit-Change-Number: 13102 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 07 Nov 2019 17:18:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>