<p>snuffy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13162">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Allow Cisco phones to exchange presence information with Asterisk.<br><br>Cisco phones lie about what style of information they accept, add a<br>workaround to change our responses to something it can understand.<br><br>Asks for response in cpim-pidf+xml format, but can only process pidf+xml.<br><br>ASTERISK-28603<br><br>Change-Id: Ib5a2944de0e280d3c92eed42d91a0bcb0bcf387c<br>---<br>M res/res_pjsip_pubsub.c<br>1 file changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/62/13162/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c</span><br><span>index e26f250..74f1248 100644</span><br><span>--- a/res/res_pjsip_pubsub.c</span><br><span>+++ b/res/res_pjsip_pubsub.c</span><br><span>@@ -822,8 +822,12 @@</span><br><span>        const struct ast_sip_subscription_handler *handler)</span><br><span> {</span><br><span>     pjsip_accept_hdr *accept_header = (pjsip_accept_hdr *) &rdata->msg_info.msg->hdr;</span><br><span style="color: hsl(120, 100%, 40%);">+   pjsip_user_agent_hdr *user_agent_header;</span><br><span style="color: hsl(120, 100%, 40%);">+      static const pj_str_t USER_AGENT = { "User-Agent", 10 };</span><br><span style="color: hsl(120, 100%, 40%);">+    char *user_agent = NULL;</span><br><span>     char accept[AST_SIP_MAX_ACCEPT][64];</span><br><span>         size_t num_accept_headers = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+        size_t alloc_size = 0;</span><br><span> </span><br><span>   while ((accept_header = pjsip_msg_find_hdr(rdata->msg_info.msg, PJSIP_H_ACCEPT, accept_header->next)) &&</span><br><span>               (num_accept_headers < AST_SIP_MAX_ACCEPT)) {</span><br><span>@@ -845,6 +849,17 @@</span><br><span>               num_accept_headers = 1;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ user_agent_header = pjsip_msg_find_hdr_by_name(rdata->msg_info.msg, &USER_AGENT, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (user_agent_header) {</span><br><span style="color: hsl(120, 100%, 40%);">+              alloc_size = pj_strlen(&user_agent_header->hvalue) + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+                user_agent = ast_alloca(alloc_size);</span><br><span style="color: hsl(120, 100%, 40%);">+          ast_copy_pj_str(user_agent, &user_agent_header->hvalue, alloc_size);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+         if (strstr(user_agent,"Cisco"))</span><br><span style="color: hsl(120, 100%, 40%);">+                     ast_copy_string(accept[0], "application/pidf+xml", sizeof(accept[0]));</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        return find_body_generator(accept, num_accept_headers, handler->body_type);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13162">change 13162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13162"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib5a2944de0e280d3c92eed42d91a0bcb0bcf387c </div>
<div style="display:none"> Gerrit-Change-Number: 13162 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: snuffy <snuffy22@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>