<p>Salah Ahmed has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13074">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Crash during "pjsip show channelstats" execution<br><br>During execution "pjsip show channelstats" cli command by an<br>external module asterisk crashed. It seems this is a separate<br>thread running to fetch and print rtp stats. The crash happened on<br>the ao2_lock method, just before it going to read the rtp stats on<br>a rtp instance. According to gdb backtrace log, it seems the<br>session media was already cleaned up at that moment.<br><br>ASTERISK-28578<br><br>Change-Id: I3e05980dd4694577be6d39be2c21a5736bae3c6f<br>---<br>M channels/pjsip/cli_commands.c<br>1 file changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/74/13074/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/pjsip/cli_commands.c b/channels/pjsip/cli_commands.c</span><br><span>index 3250607..734b0e2 100644</span><br><span>--- a/channels/pjsip/cli_commands.c</span><br><span>+++ b/channels/pjsip/cli_commands.c</span><br><span>@@ -339,14 +339,14 @@</span><br><span>   struct ast_sip_cli_context *context = arg;</span><br><span>   const struct ast_channel_snapshot *snapshot = obj;</span><br><span>   struct ast_channel *channel = ast_channel_get_by_name(snapshot->base->name);</span><br><span style="color: hsl(0, 100%, 40%);">-      struct ast_sip_channel_pvt *cpvt = channel ? ast_channel_tech_pvt(channel) : NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+    struct ast_sip_channel_pvt *cpvt = NULL;</span><br><span>     struct ast_sip_session *session;</span><br><span>     struct ast_sip_session_media *media;</span><br><span style="color: hsl(0, 100%, 40%);">-    struct ast_rtp_instance *rtp;</span><br><span>        struct ast_rtp_instance_stats stats;</span><br><span>         char *print_name = NULL;</span><br><span>     char *print_time = alloca(32);</span><br><span>       char codec_in_use[7];</span><br><span style="color: hsl(120, 100%, 40%);">+ int stats_res = -1;</span><br><span> </span><br><span>      ast_assert(context->output_buffer != NULL);</span><br><span> </span><br><span>@@ -357,7 +357,8 @@</span><br><span> </span><br><span>         ast_channel_lock(channel);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  session = cpvt->session;</span><br><span style="color: hsl(120, 100%, 40%);">+   cpvt = ast_channel_tech_pvt(channel);</span><br><span style="color: hsl(120, 100%, 40%);">+ session = cpvt ? cpvt->session : NULL;</span><br><span>    if (!session) {</span><br><span>              ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->base->name);</span><br><span>          ast_channel_unlock(channel);</span><br><span>@@ -373,14 +374,13 @@</span><br><span>                 return 0;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   rtp = ao2_bump(media->rtp);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       codec_in_use[0] = '\0';</span><br><span> </span><br><span>  if (ast_channel_rawreadformat(channel)) {</span><br><span>            ast_copy_string(codec_in_use, ast_format_get_name(ast_channel_rawreadformat(channel)), sizeof(codec_in_use));</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ stats_res = ast_rtp_instance_get_stats(media->rtp, &stats, AST_RTP_INSTANCE_STAT_ALL);</span><br><span>        ast_channel_unlock(channel);</span><br><span> </span><br><span>     print_name = ast_strdupa(snapshot->base->name);</span><br><span>@@ -389,7 +389,7 @@</span><br><span> </span><br><span>      ast_format_duration_hh_mm_ss(ast_tvnow().tv_sec - snapshot->base->creationtime.tv_sec, print_time, 32);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       if (ast_rtp_instance_get_stats(rtp, &stats, AST_RTP_INSTANCE_STAT_ALL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (stats_res == -1) {</span><br><span>               ast_str_append(&context->output_buffer, 0, "%s direct media\n", snapshot->base->name);</span><br><span>        } else {</span><br><span>             ast_str_append(&context->output_buffer, 0,</span><br><span>@@ -414,7 +414,6 @@</span><br><span>              );</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   ao2_cleanup(rtp);</span><br><span>    ao2_cleanup(channel);</span><br><span> </span><br><span>    return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13074">change 13074</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13074"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: I3e05980dd4694577be6d39be2c21a5736bae3c6f </div>
<div style="display:none"> Gerrit-Change-Number: 13074 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Salah Ahmed <txrubel@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>