<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Trying to add new patch set...</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/12981">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12981/1/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12981/1/apps/app_voicemail.c@5511">Patch Set #1, Line 5511:</a> <code style="font-family:monospace,monospace">fopen</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">There is a utility function called ast_file_is_readable which might be better</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Using ast_file_is_readable in next patch, thanks!</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12981/1/apps/app_voicemail.c@5514">Patch Set #1, Line 5514:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (c)<br> *c = '\0';<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Always use braces with an "if".</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12981/1/apps/app_voicemail.c@5518">Patch Set #1, Line 5518:</a> <code style="font-family:monospace,monospace">fopen</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12981/1/apps/app_voicemail.c@5558">Patch Set #1, Line 5558:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> } else {<br> if (!strcasecmp(format, "wav")) {<br> if (vmu->volgain < -.001 || vmu->volgain > .001) {<br> res = snprintf(sox_gain_cmd, sizeof(sox_gain_cmd), "sox -v %.4f %s.%s -e signed-integer -b 16 %s",<br> vmu->volgain, attach, altformat, fname);<br> } else {<br> res = snprintf(sox_gain_cmd, sizeof(sox_gain_cmd), "sox %s.%s -e signed-integer -b 16 %s",<br> attach, altformat, fname);<br> }<br> } else {<br> if (vmu->volgain < -.001 || vmu->volgain > .001) {<br> res = snprintf(sox_gain_cmd, sizeof(sox_gain_cmd), "sox -v %.4f %s.%s %s",<br> vmu->volgain, attach, altformat, fname);<br> } else {<br> res = snprintf(sox_gain_cmd, sizeof(sox_gain_cmd), "sox %s.%s %s",<br> attach, altformat, fname);<br> <br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Can you explain why we need this logic? What was it about the original sox command that no longer w […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I found in testing that newer sox is not able to convert between these particular formats without additional parameters (from gsm to wav.) In the future, additional email attachment formats may need to be added, at which time a switch/case may be more desirable vs increased if/then complexity.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12981">change 12981</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12981"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I7321e7f7e7c58adbf41dd4fd7191c887b9b2eafd </div>
<div style="display:none"> Gerrit-Change-Number: 12981 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: cmaj <chris@penguinpbx.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: cmaj <chris@penguinpbx.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 14 Oct 2019 21:31:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>