<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/12932">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Sean Bright: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip mwi replaced_by_unsolicited: Increase timeouts<br><br>On some systems the test timeouts were not high enough, and were causing the<br>tests to sometimes fail if running slower. This patch increases the timeouts<br>to give enough time for test conditions to be met on slower running systems.<br><br>Change-Id: Iaaf9aa2ae4ad9b850dac90bbe4e0d4f550901940<br>---<br>M tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml<br>M tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml<br>2 files changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml</span><br><span>index 13a48a9..592aca6 100644</span><br><span>--- a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml</span><br><span>@@ -33,6 +33,7 @@</span><br><span> typename: 'pluggable_modules.EventActionModule'</span><br><span> </span><br><span> sipp-config:</span><br><span style="color: hsl(120, 100%, 40%);">+ reactor-timeout: 40</span><br><span> test-iterations:</span><br><span> -</span><br><span> # Due to the nature of SIPp, and it's handling of out of call messages</span><br><span>@@ -48,9 +49,9 @@</span><br><span> # is responsible for gracefully shutting itself down. See the scenario</span><br><span> # itself for more information.</span><br><span> #</span><br><span style="color: hsl(0, 100%, 40%);">- # Note, we must tell SIPp to cause an error on scenario timeout (20 seconds).</span><br><span style="color: hsl(120, 100%, 40%);">+ # Note, we must tell SIPp to cause an error on scenario timeout (30 seconds).</span><br><span> # This way the test will fail if the expected number of calls is not met.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '2', '-timeout_error': ''} }</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '2', '-timeout': '30', '-timeout_error': ''} }</span><br><span> - { 'key-args': {'scenario': 'solicited.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice'} }</span><br><span> </span><br><span> event-action-config:</span><br><span>diff --git a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml</span><br><span>index d875013..e430bd0 100644</span><br><span>--- a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml</span><br><span>@@ -33,6 +33,7 @@</span><br><span> typename: 'pluggable_modules.EventActionModule'</span><br><span> </span><br><span> sipp-config:</span><br><span style="color: hsl(120, 100%, 40%);">+ reactor-timeout: 40</span><br><span> test-iterations:</span><br><span> -</span><br><span> # Due to the nature of SIPp, and it's handling of out of call messages</span><br><span>@@ -48,9 +49,9 @@</span><br><span> # is responsible for gracefully shutting itself down. See the scenario</span><br><span> # itself for more information.</span><br><span> #</span><br><span style="color: hsl(0, 100%, 40%);">- # Note, we must tell SIPp to cause an error on scenario timeout (20 seconds).</span><br><span style="color: hsl(120, 100%, 40%);">+ # Note, we must tell SIPp to cause an error on scenario timeout (30 seconds).</span><br><span> # This way the test will fail if the expected number of calls is not met.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '3', '-timeout_error': ''} }</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '3', '-timeout': '30', '-timeout_error': ''} }</span><br><span> - { 'key-args': {'scenario': 'solicited.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice'} }</span><br><span> </span><br><span> event-action-config:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/12932">change 12932</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/12932"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaaf9aa2ae4ad9b850dac90bbe4e0d4f550901940 </div>
<div style="display:none"> Gerrit-Change-Number: 12932 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>