<p>Alexei Gradinari has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/12952">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip_pubsub: add endpoint to some warning<br><br>There are some warning messages which are not informative without endpoint:<br>"No registered subscribe handler for event presence.winfo"<br>"No registered publish handler for event presence"<br><br>This patch adds an endpoint name to these messages.<br><br>Change-Id: Ia2811ec226d8a12659b4f9d4d224b48289650827<br>---<br>M res/res_pjsip_pubsub.c<br>1 file changed, 12 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/52/12952/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c</span><br><span>index 8f400b5..29791a7 100644</span><br><span>--- a/res/res_pjsip_pubsub.c</span><br><span>+++ b/res/res_pjsip_pubsub.c</span><br><span>@@ -766,14 +766,20 @@</span><br><span> </span><br><span>     event_header = pjsip_msg_find_hdr_by_name(rdata->msg_info.msg, &str_event_name, rdata->msg_info.msg->hdr.next);</span><br><span>         if (!event_header) {</span><br><span style="color: hsl(0, 100%, 40%);">-            ast_log(LOG_WARNING, "Incoming SUBSCRIBE request with no Event header\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          struct ast_sip_endpoint *endpoint = ast_pjsip_rdata_get_endpoint(rdata);</span><br><span style="color: hsl(120, 100%, 40%);">+              ast_log(LOG_WARNING, "Incoming SUBSCRIBE request from %s with no Event header\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   endpoint ? ast_sorcery_object_get_id(endpoint) : "Unknown");</span><br><span style="color: hsl(120, 100%, 40%);">+                ao2_cleanup(endpoint);</span><br><span>               return NULL;</span><br><span>         }</span><br><span>    ast_copy_pj_str(event, &event_header->event_type, sizeof(event));</span><br><span> </span><br><span>         handler = find_sub_handler_for_event_name(event);</span><br><span>    if (!handler) {</span><br><span style="color: hsl(0, 100%, 40%);">-         ast_log(LOG_WARNING, "No registered subscribe handler for event %s\n", event);</span><br><span style="color: hsl(120, 100%, 40%);">+              struct ast_sip_endpoint *endpoint = ast_pjsip_rdata_get_endpoint(rdata);</span><br><span style="color: hsl(120, 100%, 40%);">+              ast_log(LOG_WARNING, "No registered subscribe handler for event %s from %s\n", event,</span><br><span style="color: hsl(120, 100%, 40%);">+                       endpoint ? ast_sorcery_object_get_id(endpoint) : "Unknown");</span><br><span style="color: hsl(120, 100%, 40%);">+                ao2_cleanup(endpoint);</span><br><span>       }</span><br><span> </span><br><span>        return handler;</span><br><span>@@ -3294,7 +3300,8 @@</span><br><span> </span><br><span>  event_header = pjsip_msg_find_hdr_by_name(rdata->msg_info.msg, &str_event_name, rdata->msg_info.msg->hdr.next);</span><br><span>         if (!event_header) {</span><br><span style="color: hsl(0, 100%, 40%);">-            ast_log(LOG_WARNING, "Incoming PUBLISH request with no Event header\n");</span><br><span style="color: hsl(120, 100%, 40%);">+            ast_log(LOG_WARNING, "Incoming PUBLISH request from %s with no Event header\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     ast_sorcery_object_get_id(endpoint));</span><br><span>                pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 489, NULL, NULL, NULL);</span><br><span>           return PJ_TRUE;</span><br><span>      }</span><br><span>@@ -3302,7 +3309,8 @@</span><br><span> </span><br><span>        handler = find_pub_handler(event);</span><br><span>   if (!handler) {</span><br><span style="color: hsl(0, 100%, 40%);">-         ast_log(LOG_WARNING, "No registered publish handler for event %s\n", event);</span><br><span style="color: hsl(120, 100%, 40%);">+                ast_log(LOG_WARNING, "No registered publish handler for event %s from %s\n", event,</span><br><span style="color: hsl(120, 100%, 40%);">+                 ast_sorcery_object_get_id(endpoint));</span><br><span>                pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 489, NULL, NULL, NULL);</span><br><span>           return PJ_TRUE;</span><br><span>      }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12952">change 12952</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12952"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ia2811ec226d8a12659b4f9d4d224b48289650827 </div>
<div style="display:none"> Gerrit-Change-Number: 12952 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>