<p><a href="https://gerrit.asterisk.org/c/asterisk/+/12863">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12863/1/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12863/1/res/res_rtp_asterisk.c@4891">Patch Set #1, Line 4891:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You need to unlock the instance in the nominal path as well. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oh yeah, duh. Must've completely overlooked that when writing it, yet somehow I remember the failure cases :)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12863/1/res/res_rtp_asterisk.c@4949">Patch Set #1, Line 4949:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ao2_lock(instance);<br> rtcpheader = bdata;<br><br> res = ast_rtcp_generate_report(instance, rtcpheader, rtcp_report, &sr);<br> if (res == 0 || res == 1) {<br> ast_debug(1, "Failed to add %s report to REMB packet!\n", sr ? "SR" : "RR");<br> ao2_unlock(instance);<br> return;<br> }<br><br> packet_len += res;<br><br> res = ast_rtcp_generate_sdes(instance, rtcpheader + packet_len, rtcp_report);<br> if (res == 0 || res == 1) {<br> ast_debug(1, "Failed to add SDES to REMB packet!\n");<br> ao2_unlock(instance);<br> return;<br> }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If I'm not missing anything this is pretty much the same code as above. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah, it may be beneficial to refactor it anyways since there could be more RTCP packets added in the future that will need this same format prefixing it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12863">change 12863</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12863"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ieb140e9c22568a251a564cd953dd22cd33244605 </div>
<div style="display:none"> Gerrit-Change-Number: 12863 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Sep 2019 16:06:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>