<p><a href="https://gerrit.asterisk.org/c/asterisk/+/12775">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12775/1/rest-api/api-docs/channels.json">File rest-api/api-docs/channels.json:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12775/1/rest-api/api-docs/channels.json@1761">Patch Set #1, Line 1761:</a> <code style="font-family:monospace,monospace">                                    "responseClass": "Channel",</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Would it be better to encapsulate this in another, so that if we need to return additional information besides what is present on a channel we don't need a second interface that returns that class instead of Channel for backwards compatibility?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">We could but I was thinking that we could just add channel variables to pass back other data.  That's how UnicastRTP passes back the local ip address and port for instance.  It also keeps the processing simple since we can just pass the request off to ari_channels_handle_originate_with_id once we determine the correct channel driver to use.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12775">change 12775</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12775"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I9618899198880b4c650354581b50c0401b58bc46 </div>
<div style="display:none"> Gerrit-Change-Number: 12775 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Aug 2019 13:17:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>