<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2:</p><p style="white-space: pre-wrap; word-wrap: break-word;">(3 comments)</p><p style="white-space: pre-wrap; word-wrap: break-word;">See previous comments, probably best to use SIPFROMDOMAIN for consistency with other places in PJSIP land.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I understood it as the name PJSIP_FROM_DOMAIN was more suitable. No?<br>>> we should at least make it a variable name that we can live with long term, like PJSIP_FROM_DOMAIN.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">OK, I missed you previous comment.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I will redo with the name SIPFROMDOMAIN.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11651">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11651">change 11651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e </div>
<div style="display:none"> Gerrit-Change-Number: 11651 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Stas Kobzar <stas@modulis.ca> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Stas Kobzar <stas@modulis.ca> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Aug 2019 17:24:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>