<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for the review Richard.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Quick question: do you have any use for the other patches I attached to https://issues.asterisk.org/jira/browse/ASTERISK-28282 ?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">The one for mixmonitor to reduce locking I'm not sure how useful it is.  It does introduce reentrancy problems with those new variables.</p><p style="white-space: pre-wrap; word-wrap: break-word;">ASTERISK-28282_no_sip_poke_peer_now_if_no_qualify.patch - I cannot say much about that patch as I don't know what it is trying to fix.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Those other patches are chan_sip specific sched debugging, changes to induce the deadlock, or combined in this patch.</p><p style="white-space: pre-wrap; word-wrap: break-word;">So they aren't that useful.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/10991">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/10991">change 10991</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/10991"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ic26777fa0732725e6ca7010df17af77a012aa856 </div>
<div style="display:none"> Gerrit-Change-Number: 10991 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Jul 2019 22:34:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>