<p><a href="https://gerrit.asterisk.org/c/asterisk/+/11252">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11252/1/res/res_pjsip/pjsip_message_filter.c">File res/res_pjsip/pjsip_message_filter.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11252/1/res/res_pjsip/pjsip_message_filter.c@114">Patch Set #1, Line 114:</a> <code style="font-family:monospace,monospace">transport_state</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Feel free to ignore all of this:</p><p style="white-space: pre-wrap; word-wrap: break-word;">While you're in here... `transport_state` will never be NULL, so this check can be removed.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This `if` statement could be negated:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (transport_state->type == AST_TRANSPORT_UDP<br>    && !pj_strcmp(&transport_state->transport->local_name.host, address)<br>    && transport_state->transport->local_name.port == port) {</pre><p style="white-space: pre-wrap; word-wrap: break-word;">And you could move the `sip_transport` assignment into the block which would simplify a little.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11252">change 11252</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11252"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I40e35b5a339121300c80075c30db47201a6c374e </div>
<div style="display:none"> Gerrit-Change-Number: 11252 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Apr 2019 13:18:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>