<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11201">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11201/3//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11201/3//COMMIT_MSG@7">Patch Set #3, Line 7:</a> <code style="font-family:monospace,monospace">Fixed duplicated subscription adding</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should have res_stasis: at the front, and also better describe the new change (regarding forwarding).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11201/3/include/asterisk/stasis.h">File include/asterisk/stasis.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11201/3/include/asterisk/stasis.h@137">Patch Set #3, Line 137:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> * It is safe to duplicate subscribing. Once the subscriber subscribes given topic<br> * already, it doesn't increase subscriber reference count. So, don't have to<br> * unsubscribe many times for in case of duplicated subscribing.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think this should be changed due to the reason I gave regarding forwarding.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11201/3/main/stasis.c">File main/stasis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11201/3/main/stasis.c@1050">Patch Set #3, Line 1050:</a> <code style="font-family:monospace,monospace">static int topic_add_subscription(struct stasis_topic *topic, struct stasis_subscription *sub)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think the changes in here are needed any longer due to the reason I previously gave, as forwarding would only cause this and it now checks.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11201/3/main/strings.c">File main/strings.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11201/3/main/strings.c@222">Patch Set #3, Line 222:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">int ast_str_container_add_uniq(struct ao2_container *str_container, const char *add)<br>{<br> void *tmp;<br><br> tmp = ao2_find(str_container, add, OBJ_SEARCH_KEY);<br> if (tmp) {<br> ao2_cleanup(tmp);<br> return -1;<br> }<br><br> return ast_str_container_add(str_container, add);<br>}<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">No longer needed</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11201">change 11201</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11201"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00bd627e4cc21aba0535d2695460a04f06f6e699 </div>
<div style="display:none"> Gerrit-Change-Number: 11201 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Apr 2019 11:53:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>