<p>Christian Savinovich has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11230">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">config.c: parsing_extconfig.conf<br><br>When extconfig.conf file is parsed, the code previously searched for<br>character comma without verifying if error (null or blank).  This caused<br>a segmentation error. An "if" was introduced, and if null or blank a<br>warning is printed and line is skipped.<br><br>Change-Id: Id76b452d8f330d11c2742c37232761ad71472a8b<br>---<br>M main/config.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/11230/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/config.c b/main/config.c</span><br><span>index f694c2b..1c5262d 100644</span><br><span>--- a/main/config.c</span><br><span>+++ b/main/config.c</span><br><span>@@ -2902,6 +2902,10 @@</span><br><span>       for (v = ast_variable_browse(config, "settings"); v; v = v->next) {</span><br><span>             char buf[512];</span><br><span>               ast_copy_string(buf, v->value, sizeof(buf));</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!strstr(buf,",") || !strlen(buf)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     ast_log(LOG_WARNING,"extconfig.conf: value '%s' ignored due to wrong format\n", v->value);</span><br><span style="color: hsl(120, 100%, 40%);">+                       continue;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>            stringp = buf;</span><br><span>               driver = strsep(&stringp, ",");</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11230">change 11230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Id76b452d8f330d11c2742c37232761ad71472a8b </div>
<div style="display:none"> Gerrit-Change-Number: 11230 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Christian Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>