<p>Kevin Harwell has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11193">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bridge_softmix & rtp_engine: Make REMB mantissa a uint64_t<br><br>REMB's exponent is 6-bits (0..63), however the mantissa is stored in Asterisk<br>as an unsigned integer, which is typically 32-bits. A higher exponent value<br>resulted in bits being shifted off the "front" of the mantissa, which caused<br>the wrong value to be sent to the browser.<br><br>This patch specifies the mantissa as an unsigned 64-bit value now, so larger<br>values can be accommodated.<br><br>ASTERISK-28255<br><br>Change-Id: Ice00fdd16693b16b41230664be5d9f0e465b239e<br>---<br>M bridges/bridge_softmix.c<br>M include/asterisk/rtp_engine.h<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/93/11193/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bridges/bridge_softmix.c b/bridges/bridge_softmix.c</span><br><span>index 290ea2b..20af951 100644</span><br><span>--- a/bridges/bridge_softmix.c</span><br><span>+++ b/bridges/bridge_softmix.c</span><br><span>@@ -76,7 +76,7 @@</span><br><span>  /*! The REMB to send to the source which is collecting REMB reports */</span><br><span>       struct ast_rtp_rtcp_feedback feedback;</span><br><span>       /*! The maximum bitrate */</span><br><span style="color: hsl(0, 100%, 40%);">-      unsigned int bitrate;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint64_t bitrate;</span><br><span> };</span><br><span> </span><br><span> struct softmix_stats {</span><br><span>@@ -1334,7 +1334,7 @@</span><br><span>        struct softmix_bridge_data *softmix_data, struct softmix_channel *sc)</span><br><span> {</span><br><span>   int i;</span><br><span style="color: hsl(0, 100%, 40%);">-  unsigned int bitrate;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint64_t bitrate;</span><br><span> </span><br><span>        /* If there are no video sources that we are a receiver of then we have noone to</span><br><span>      * report REMB to.</span><br><span>diff --git a/include/asterisk/rtp_engine.h b/include/asterisk/rtp_engine.h</span><br><span>index 98d7773..4cf3eba 100644</span><br><span>--- a/include/asterisk/rtp_engine.h</span><br><span>+++ b/include/asterisk/rtp_engine.h</span><br><span>@@ -346,7 +346,7 @@</span><br><span>  * \brief A REMB feedback message (see draft-alvestrand-rmcat-remb-03 for details) */</span><br><span> struct ast_rtp_rtcp_feedback_remb {</span><br><span>    unsigned int br_exp;            /*!< Exponential scaling of the mantissa for the maximum total media bit rate value */</span><br><span style="color: hsl(0, 100%, 40%);">-       unsigned int br_mantissa;       /*!< The mantissa of the maximum total media bit rate */</span><br><span style="color: hsl(120, 100%, 40%);">+   uint64_t br_mantissa;           /*!< The mantissa of the maximum total media bit rate */</span><br><span> };</span><br><span> </span><br><span> /*!</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11193">change 11193</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11193"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ice00fdd16693b16b41230664be5d9f0e465b239e </div>
<div style="display:none"> Gerrit-Change-Number: 11193 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>