<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11172">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_sip: Ensure 'qualifygap' isn't negative<br><br>Passing negative intervals to the scheduler rips a hole in the<br>space-time continuum.<br><br>ASTERISK-25792 #close<br>Reported by: Paul Sandys<br><br>Change-Id: Ie706f21cee05f76ffb6f7d89e9c867930ee7bcd7<br>---<br>M channels/chan_sip.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_sip.c b/channels/chan_sip.c</span><br><span>index ac922fa..ce88e52 100644</span><br><span>--- a/channels/chan_sip.c</span><br><span>+++ b/channels/chan_sip.c</span><br><span>@@ -32900,7 +32900,8 @@</span><br><span>                                 ast_log(LOG_WARNING, "Usage of SIP_CAUSE is deprecated.  Please use HANGUPCAUSE instead.\n");</span><br><span>                      }</span><br><span>            } else if (!strcasecmp(v->name, "qualifygap")) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   if (sscanf(v->value, "%30d", &global_qualify_gap) != 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (sscanf(v->value, "%30d", &global_qualify_gap) != 1</span><br><span style="color: hsl(120, 100%, 40%);">+                               || global_qualify_gap < 0) {</span><br><span>                              ast_log(LOG_WARNING, "Invalid qualifygap '%s' at line %d of %s\n", v->value, v->lineno, config);</span><br><span>                             global_qualify_gap = DEFAULT_QUALIFY_GAP;</span><br><span>                    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11172">change 11172</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11172"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ie706f21cee05f76ffb6f7d89e9c867930ee7bcd7 </div>
<div style="display:none"> Gerrit-Change-Number: 11172 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>