<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11134">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11134/4/res/res_stasis.c">File res/res_stasis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11134/4/res/res_stasis.c@126">Patch Set #4, Line 126:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   msg = ast_json_pack("{s: s, s: o, s: o}",<br>           "type", "StasisEnd",<br>              "timestamp", ast_json_copy(ast_json_object_get(payload->blob, "timestamp")),<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Here this can use the other method like you had before of bumping the ref. This behavior changed between 13 and 16 it seems (looks like it is now threadsafe). See commit 7b0dbda9 (16 branch) for more information/details if you like.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11134/4/res/res_stasis.c@158">Patch Set #4, Line 158:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     msg = ast_json_pack("{s: s, s: o, s: o, s: o}",<br>             "type", "StasisStart",<br>            "timestamp", ast_json_copy(ast_json_object_get(payload->blob, "timestamp")),<br>           "args", ast_json_deep_copy(ast_json_object_get(payload->blob, "args")),<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Similar to above. This can be undone and as it should use the ref bump method.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11134">change 11134</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11134"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I5eb8380fc472f1100535a6bc4983c64767026116 </div>
<div style="display:none"> Gerrit-Change-Number: 11134 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Mar 2019 17:54:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>