<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">One good place would be the documentation of the AgentConnect event, stating that "the called channel is already dialing, so events on that channel may or may not have been sent already".<br></p></blockquote></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">The documentation for an event is generated from the XML description of the event located in the Asterisk source (usually somewhere near the top of the *.c file). If you'd like to update the documentation for an event I'd suggest making this patch do just that while dropping the change. The "AgentCalled" docs can be found in the XML in app_queue.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Also a general explanation of event ordering on https://wiki.asterisk.org/wiki/display/AST/Interfaces would be a good idea, as this applies both the AMI and ARI.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">(sorry, meant to say AgentCalled instead of AgentConnect)</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I added a few sentences to the page:</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://wiki.asterisk.org/wiki/display/AST/Interfaces</p><p style="white-space: pre-wrap; word-wrap: break-word;">Hopefully that is what you had in mind.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks, let's close this PR.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11058">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11058">change 11058</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11058"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Id0865fb306136f30a1aa8be82f3753c47059ff2d </div>
<div style="display:none"> Gerrit-Change-Number: 11058 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Mar 2019 10:16:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>