<p>Sean Bright <strong>uploaded patch set #3</strong> to the change originally created by George Joseph.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11114">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app.c:  Remove deletion of pool topic on mwi state delete<br><br>As part of an earlier voicemail refactor, ast_delete_mwi_state_full<br>was modified to remove the pool topic for a mailbox when the state<br>was deleted.  This was an attempt to prevent stale topics from<br>accumulating when app_voicemail was reloaded and a mailbox went<br>away.  Unfortunately because of the fact that when app_voicemail<br>reloads, ALL mailboxes are deleted then only current ones recreated,<br>topics were being removed from the pool that still had subscribers<br>on them, then recreated as new topics of the same name.  So now<br>modules like res_pjsip_mwi are listening on a topic that will<br>never receive any messages because app_voicemail is publishing on<br>a different topic that happens to have the same name.  The solutiuon<br>to this is not easy and given that accumulating topics for<br>deleted mailboxes is less evil that not sending NOTIFYs...<br><br>* Removed the call to stasis_topic_pool_delete_topic in<br>  ast_delete_mwi_state_full.<br><br>Also:<br><br>* Fixed a topic reference leak in res_pjsip_mwi<br>  mwi_stasis_subscription_alloc.<br><br>* Added some debugging to mwi_stasis_subscription_alloc,<br>  stasis_topic_create, and topic_dtor.<br><br>* Fixed a topic reference leak in an error path in<br>  internal_stasis_subscribe.<br><br>ASTERISK-28306<br>Reported-by: Jared Hull<br><br>Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27<br>---<br>M main/app.c<br>M main/stasis.c<br>M res/res_pjsip_mwi.c<br>3 files changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/14/11114/3</pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11114">change 11114</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11114"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27 </div>
<div style="display:none"> Gerrit-Change-Number: 11114 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>