<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11096">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_queue: Handle empty 'interface' in queue member config<br><br>While the 'interface' column is a NOT NULL, the empty string is still<br>allowed. res_config_odbc treats the empty string as a NULL and we crash<br>when trying to dereference.<br><br>Also cleaned up an adjacent error message for consistency.<br><br>ASTERISK-28168 #close<br><br>Change-Id: I55e012b540fbcda99bb40bede3099b7ae5db8202<br>---<br>M apps/app_queue.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_queue.c b/apps/app_queue.c</span><br><span>index 8b34d73..10dd06a 100644</span><br><span>--- a/apps/app_queue.c</span><br><span>+++ b/apps/app_queue.c</span><br><span>@@ -3410,7 +3410,14 @@</span><br><span>     const char *wrapuptime_str = ast_variable_retrieve(member_config, category, "wrapuptime");</span><br><span> </span><br><span>     if (ast_strlen_zero(rt_uniqueid)) {</span><br><span style="color: hsl(0, 100%, 40%);">-             ast_log(LOG_WARNING, "Realtime field uniqueid is empty for member %s\n", S_OR(membername, "NULL"));</span><br><span style="color: hsl(120, 100%, 40%);">+               ast_log(LOG_WARNING, "Realtime field 'uniqueid' is empty for member %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  S_OR(membername, "NULL"));</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (ast_strlen_zero(interface)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             ast_log(LOG_WARNING, "Realtime field 'interface' is empty for member %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                 S_OR(membername, "NULL"));</span><br><span>                 return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11096">change 11096</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11096"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I55e012b540fbcda99bb40bede3099b7ae5db8202 </div>
<div style="display:none"> Gerrit-Change-Number: 11096 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>