<p>Friendly Automation would like George Joseph to <strong>review</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11070">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip_sdp_rtp:  Fix return code from apply_negotiated_sdp_stream<br><br>apply_negotiated_sdp_stream was returning a "1" when no joint<br>capabilities were found on an outgoing call instead of a "-1".<br>This indicated to res_pjsip_session that the handler DID handle<br>the sdp when in fact it didn't.  Without the appropriate setup,<br>a subsequent media frame coming in would have an invalid stream_num<br>and cause a seg fault when the stream was attempted to be retrieved.<br><br>apply_negotiated_sdp_stream now returns the correct "-1" and any<br>media is now discarded before it reaches the core stream processing.<br><br>ASTERISK-28620<br>Reported by: Sotiris Ganouris<br><br>Change-Id: Ia095cb16b4862f2f6ad6d2d2a77453fa2542371f<br>---<br>M res/res_pjsip_sdp_rtp.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/11070/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip_sdp_rtp.c b/res/res_pjsip_sdp_rtp.c</span><br><span>index 9686960..cba494a 100644</span><br><span>--- a/res/res_pjsip_sdp_rtp.c</span><br><span>+++ b/res/res_pjsip_sdp_rtp.c</span><br><span>@@ -1946,7 +1946,7 @@</span><br><span>  }</span><br><span> </span><br><span>        if (set_caps(session, session_media, session_media_transport, remote_stream, 0, asterisk_stream)) {</span><br><span style="color: hsl(0, 100%, 40%);">-             return 1;</span><br><span style="color: hsl(120, 100%, 40%);">+             return -1;</span><br><span>   }</span><br><span> </span><br><span>        /* Set the channel uniqueid on the RTP instance now that it is becoming active */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11070">change 11070</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11070"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ia095cb16b4862f2f6ad6d2d2a77453fa2542371f </div>
<div style="display:none"> Gerrit-Change-Number: 11070 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>