<p style="white-space: pre-wrap; word-wrap: break-word;">These comments only apply if the patch is to be cherry-picked to earlier branches.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/10986">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10986/4/include/asterisk/bridge.h">File include/asterisk/bridge.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10986/4/include/asterisk/bridge.h@333">Patch Set #4, Line 333:</a> <code style="font-family:monospace,monospace"> struct timeval creationtime;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a public struct. You need to add to the end of it to not break ABI if this gets cherry-picked to earlier branches.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10986/4/include/asterisk/bridge.h@396">Patch Set #4, Line 396:</a> <code style="font-family:monospace,monospace"> struct timeval creationtime;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a public struct. You need to add to the end of it to not break ABI if this gets cherry-picked to earlier branches.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/10986">change 10986</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/10986"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I460238c488eca4d216b9176576211cb03286e040 </div>
<div style="display:none"> Gerrit-Change-Number: 10986 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 27 Feb 2019 17:14:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>