<p><a href="https://gerrit.asterisk.org/10937">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10937/6/res/res_stasis.c">File res/res_stasis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10937/6/res/res_stasis.c@1416">Patch Set #6, Line 1416:</a> <code style="font-family:monospace,monospace"> break;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think these are both ok. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">yes you are right about "msg". It actually breaks out of the for loop, and not the while loop, so is okay as it does get unref'd. And adding the unref for next_app at the end of the loop should also take care of this case.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10937/6/res/res_stasis.c@1419">Patch Set #6, Line 1419:</a> <code style="font-family:monospace,monospace"> if (r == 0) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think it needs to be there, strictly for that error scenario. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">No clue what I was thinking. You're correct.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10937/6/res/stasis/control.h">File res/stasis/control.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10937/6/res/stasis/control.h@40">Patch Set #6, Line 40:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> *<br> * \note This function inherits app's ref rather than bumping app!<br> * If something goes wrong, ao2_cleanup is called on the app.<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The main reason was to do away with having to have a variable named "app" inside of the stasis_app_e […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Makes sense you are trying to remove the variable, but I lean toward keeping it for the sake of code consistency and slightly less obfuscation. But that's just me if you feel strongly then at least you've documented the behavior.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10937/6/res/stasis/control.c">File res/stasis/control.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10937/6/res/stasis/control.c@86">Patch Set #6, Line 86:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /*!<br> * The list of arguments to pass to StasisStart when moving to another app.<br> */<br> char **argv;<br> /*!<br> * The number of arguments argv contains.<br> */<br> int argc;<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Posting what we talked about in stand-up for public visibility: stasis start requires a parameter of […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can you use "AST_VECTOR_STEAL_ELEMENTS"? If you're moving from one to the other the old app no longer needs the arguments. Just "steal"/dump them pass in and create add as a vector in the new app?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10937">change 10937</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10937"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I43d12b10045a98a8d42541889b85695be26f288a </div>
<div style="display:none"> Gerrit-Change-Number: 10937 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Feb 2019 00:10:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>