<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10936">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10936/4//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10936/4//COMMIT_MSG@13">Patch Set #4, Line 13:</a> <code style="font-family:monospace,monospace">3. Fedora and Ubuntu</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove this as it's not really a dependency of the problem. It's more that there is a bug in GCC 8.2.1</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10936/4/include/asterisk/sem.h">File include/asterisk/sem.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10936/4/include/asterisk/sem.h@a42">Patch Set #4, Line 42:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree with Corey to a certain extent that some of these are very simple and _should_ be inlined. For instance these here. I'd probably leave these alone, and change to "inline" instead of "force_inline"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10936/4/include/asterisk/utils.h">File include/asterisk/utils.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10936/4/include/asterisk/utils.h@a588">Patch Set #4, Line 588:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br><br><br><br><br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I wonder if this could be turned into a macro instead defined by ast_assert?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10936/4/main/audiohook.c">File main/audiohook.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10936/4/main/audiohook.c@1431">Patch Set #4, Line 1431:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">void ast_slinear_saturated_add(short *input, short *value)<br>{<br> int res;<br><br> res = (int) *input + *value;<br> if (res > 32767)<br> *input = 32767;<br> else if (res < -32768)<br> *input = -32768;<br> else<br> *input = (short) res;<br>}<br><br>void ast_slinear_saturated_subtract(short *input, short *value)<br>{<br> int res;<br><br> res = (int) *input - *value;<br> if (res > 32767)<br> *input = 32767;<br> else if (res < -32768)<br> *input = -32768;<br> else<br> *input = (short) res;<br>}<br><br>void ast_slinear_saturated_multiply(short *input, short *value)<br>{<br> int res;<br><br> res = (int) *input * *value;<br> if (res > 32767)<br> *input = 32767;<br> else if (res < -32768)<br> *input = -32768;<br> else<br> *input = (short) res;<br>}<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree with Walter. While here, we should bring this code up to par with the coding guidelines. Please add the necessary braces for each if/else statement.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10936">change 10936</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10936"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9 </div>
<div style="display:none"> Gerrit-Change-Number: 10936 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Feb 2019 22:31:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>