<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/11001">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11001/7/main/taskprocessor.c">File main/taskprocessor.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11001/7/main/taskprocessor.c@94">Patch Set #7, Line 94:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      /*! \brief Anything before the first '/' in the name (if there is one) */<br>     char *subsystem;<br>      /*! \brief Friendly name of the taskprocessor */<br>      char *name;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">One of these can be eliminated as it will always be pointing to buffer.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I suggest keeping name as the buffer and stuffing subsystem at the end of it.  Then doxygen comment that subsystem is stuffed at the end of the name[] buffer.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11001/7/main/taskprocessor.c@129">Patch Set #7, Line 129:</a> <code style="font-family:monospace,monospace">static AST_VECTOR_RW(subsystem_alert_vector ,struct subsystem_alert *) overloaded_subsystems;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit: no space before comma and space after comma</p><p style="white-space: pre-wrap; word-wrap: break-word;">...alert_vector, struct subsystem_alert...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11001/7/main/taskprocessor.c@700">Patch Set #7, Line 700:</a> <code style="font-family:monospace,monospace"> if (AST_VECTOR_INIT(&sorted_subsystems, AST_VECTOR_SIZE(&overloaded_subsystems))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">To be safe, you should get the overloaded_subsystems rd lock to retrieve the vector size.  It may grow between here and copying the vector and subsystem_copy() doesn't protect against vector growth failure.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11001/7/main/taskprocessor.c@750">Patch Set #7, Line 750:</a> <code style="font-family:monospace,monospace">                /* tps_alert_count becomes zero or non-zero */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Change left in when reverting earlier change.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/11001">change 11001</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/11001"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8c19068bb2fc26610a9f0b8624bdf577a04fcd56 </div>
<div style="display:none"> Gerrit-Change-Number: 11001 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Feb 2019 00:42:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>