<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10927">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Sean Bright: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">codecs.conf.sample: update codec opus docs<br><br>The option value "sdp" for some of the settings was removed a while back,<br>however the sample conf was not updated.<br><br>This patch removes any wording with regards to the old "sdp" option value,<br>and adjusts the defaults to what they are now.<br><br>ASTERISK-28263<br><br>Change-Id: I41bfa44e9f69446bcc5c8fd92e3675c676fdc445<br>---<br>M configs/samples/codecs.conf.sample<br>1 file changed, 12 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configs/samples/codecs.conf.sample b/configs/samples/codecs.conf.sample</span><br><span>index a87f23e..1913fda 100644</span><br><span>--- a/configs/samples/codecs.conf.sample</span><br><span>+++ b/configs/samples/codecs.conf.sample</span><br><span>@@ -161,6 +161,11 @@</span><br><span> </span><br><span> ;============================ OPUS Section Options ============================</span><br><span> ;</span><br><span style="color: hsl(120, 100%, 40%);">+; NOTE: Accurate documentation corresponding to your downloaded version of</span><br><span style="color: hsl(120, 100%, 40%);">+; codec_opus is available from Asterisk's CLI:</span><br><span style="color: hsl(120, 100%, 40%);">+;</span><br><span style="color: hsl(120, 100%, 40%);">+; *CLI> config show help codec_opus opus</span><br><span style="color: hsl(120, 100%, 40%);">+;</span><br><span> ;[opus]</span><br><span> ;type= ; Must be of type "opus" (default: "")</span><br><span> ;packet_loss= ; Encoder's packet loss percentage. Can be any number between 0</span><br><span>@@ -179,35 +184,28 @@</span><br><span> ;max_playback_rate= ; Override the maximum playback rate in the offer's SDP.</span><br><span> ; Any value between 8000 and 48000 (inclusive) is valid,</span><br><span> ; however typically it should match one of the usual opus</span><br><span style="color: hsl(0, 100%, 40%);">- ; bandwidths. A value of "sdp" is also allowed. When set</span><br><span style="color: hsl(0, 100%, 40%);">- ; to "sdp" then the value from the offer's SDP is used.</span><br><span style="color: hsl(0, 100%, 40%);">- ; (default: "sdp")</span><br><span style="color: hsl(120, 100%, 40%);">+ ; bandwidths. (default: 48000)</span><br><span> ;bitrate= ; Override the maximum average bitrate in the offer's SDP. Any value</span><br><span> ; between 500 and 512000 is valid. The following values are also</span><br><span style="color: hsl(0, 100%, 40%);">- ; allowed: auto, max, sdp. When set to "sdp" then the value from</span><br><span style="color: hsl(0, 100%, 40%);">- ; the offer's sdp is used. (default: "sdp")</span><br><span style="color: hsl(120, 100%, 40%);">+ ; allowed: auto, max. (default: auto)</span><br><span> ;cbr= ; Override the constant bit rate parameter in the offer's SDP. A value of</span><br><span> ; 0/false/no represents a variable bit rate whereas 1/true/yes represents</span><br><span style="color: hsl(0, 100%, 40%);">- ; a constant bit rate. A value of "sdp" is also allowed. When set to "sdp"</span><br><span style="color: hsl(0, 100%, 40%);">- ; then the value from the offer's sdp is used. (default: "sdp")</span><br><span style="color: hsl(120, 100%, 40%);">+ ; a constant bit rate. (default: no)</span><br><span> ;fec= ; Override the use inband fec parameter in the offer's SDP. A value of</span><br><span> ; 0/false/no represents disabled whereas 1/true/yes represents enabled.</span><br><span style="color: hsl(0, 100%, 40%);">- ; A value of "sdp" is also allowed. When set to "sdp" then the value from</span><br><span style="color: hsl(0, 100%, 40%);">- ; the offer's sdp is used. (default: "sdp")</span><br><span style="color: hsl(120, 100%, 40%);">+ ; (default: yes)</span><br><span> ;dtx= ; Override the use dtx parameter in the offer's SDP. A value of 0/false/no</span><br><span style="color: hsl(0, 100%, 40%);">- ; represents disabled whereas 1/true/yes represents enabled. A value of</span><br><span style="color: hsl(0, 100%, 40%);">- ; "sdp" is also allowed. When set to "sdp" then the value from the offer's</span><br><span style="color: hsl(0, 100%, 40%);">- ; sdp is used. (default: "sdp")</span><br><span style="color: hsl(120, 100%, 40%);">+ ; represents disabled whereas 1/true/yes represents enabled. (default: no)</span><br><span> </span><br><span> ;=============================== OPUS Examples ================================</span><br><span> ;</span><br><span> ;[opus]</span><br><span> ;type=opus</span><br><span> ;max_playback_rate=8000 ; Limit the maximum playback rate on the encoder</span><br><span style="color: hsl(0, 100%, 40%);">-;fec=no ; Force no inband fec on the encoder (i.e don't use what's on the SDP)</span><br><span style="color: hsl(120, 100%, 40%);">+;fec=no ; No inband fec</span><br><span> </span><br><span> ;[myopus]</span><br><span> ;type=opus</span><br><span> ;max_bandwidth=wide ; Maximum encoded bandwidth set to wide band (0-8000 Hz</span><br><span> ; ; audio bandwidth at 16Khz sample rate)</span><br><span style="color: hsl(0, 100%, 40%);">-;cbr=yes ; Force a constant bit rate (i.e don't use what's on the SDP)</span><br><span style="color: hsl(120, 100%, 40%);">+;cbr=yes ; Negotiate a constant bit rate</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10927">change 10927</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10927"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I41bfa44e9f69446bcc5c8fd92e3675c676fdc445 </div>
<div style="display:none"> Gerrit-Change-Number: 10927 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>