<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10924">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10924/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1//COMMIT_MSG@31">Patch Set #1, Line 31:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ast_sounds_reindex() is now a no-op but left for backwards<br>compatibility.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This does not apply to master.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10924/1/include/asterisk/media_index.h">File include/asterisk/media_index.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1/include/asterisk/media_index.h@102">Patch Set #1, Line 102:</a> <code style="font-family:monospace,monospace">int ast_media_index_update(struct ast_media_index *index,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">For master only lets replace this with a macro, wire it directly to ast_media_index_update_for_file with filename = NULL.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10924/1/main/sounds.c">File main/sounds.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1/main/sounds.c@241">Patch Set #1, Line 241:</a> <code style="font-family:monospace,monospace"> ao2_ref(sounds_index, -1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ao2_cleanup(variants)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1/main/sounds.c@276">Patch Set #1, Line 276:</a> <code style="font-family:monospace,monospace"> return 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit: return AST_MODULE_LOAD_DECLINE in 16 and master.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1/main/sounds.c@279">Patch Set #1, Line 279:</a> <code style="font-family:monospace,monospace"> return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit: return AST_MODULE_LOAD_SUCCESS in 16 and master.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1/main/sounds.c@331">Patch Set #1, Line 331:</a> <code style="font-family:monospace,monospace"> ao2_cleanup(failed_index);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Move this into `if (failed_index)` block and just use ao2_ref.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10924/1/main/sounds.c@340">Patch Set #1, Line 340:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /* This reload doesn't use config so this module doesn't require "extconfig". */<br> .reload = reload_module,<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be removed so that CLI 'module reload sounds' is deleted. Probably worth adding a separate comment to CHANGES or even UPGRADE.txt.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment does not apply to 16.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10924">change 10924</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10924"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d </div>
<div style="display:none"> Gerrit-Change-Number: 10924 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 28 Jan 2019 15:13:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>