<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10901">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Kevin Harwell: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/pjsip/hold: Allow optional reinvite.<br><br>Due to a race condition between SDP negotiation and bridging<br>it is possible for a reinvite to be sent to the calling party<br>in this test. The test did not allow this, causing a failure<br>to occur.<br><br>This change adds support for this optional reinvite.<br><br>This is part of my continuing saga to better understand the<br>test failures we're seeing.<br><br>Change-Id: Ia267cc138966dbd4449f2cab0fa56c01819a8c90<br>---<br>M tests/channels/pjsip/hold/sipp/phone_A.xml<br>1 file changed, 40 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/hold/sipp/phone_A.xml b/tests/channels/pjsip/hold/sipp/phone_A.xml</span><br><span>index 8c2ae2b..bb404a3 100644</span><br><span>--- a/tests/channels/pjsip/hold/sipp/phone_A.xml</span><br><span>+++ b/tests/channels/pjsip/hold/sipp/phone_A.xml</span><br><span>@@ -58,9 +58,13 @@</span><br><span> ]]></span><br><span> </send></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ <recv request="INVITE" optional="true" next="respond_reinvite"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ <label id="wait_for_bye"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> <recv request="BYE"/></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- <send retrans="500"></span><br><span style="color: hsl(120, 100%, 40%);">+ <send retrans="500" next="scenario_end"></span><br><span> <![CDATA[</span><br><span> SIP/2.0 200 OK</span><br><span> [last_Via:]</span><br><span>@@ -89,4 +93,39 @@</span><br><span> ]]></span><br><span> </send></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ <label id="respond_reinvite"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ <send retrans="500" next="scenario_end"></span><br><span style="color: hsl(120, 100%, 40%);">+ <![CDATA[</span><br><span style="color: hsl(120, 100%, 40%);">+ SIP/2.0 200 OK</span><br><span style="color: hsl(120, 100%, 40%);">+ [last_Via:]</span><br><span style="color: hsl(120, 100%, 40%);">+ [last_From:]</span><br><span style="color: hsl(120, 100%, 40%);">+ [last_To:];tag=[call_number]</span><br><span style="color: hsl(120, 100%, 40%);">+ [last_Call-ID:]</span><br><span style="color: hsl(120, 100%, 40%);">+ [last_CSeq:]</span><br><span style="color: hsl(120, 100%, 40%);">+ Contact: <sip:[field0]@[local_ip]:[local_port];transport=[transport]></span><br><span style="color: hsl(120, 100%, 40%);">+ Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, INFO, MESSAGE, SUBSCRIBE, NOTIFY, PRACK, UPDATE, REFER</span><br><span style="color: hsl(120, 100%, 40%);">+ Supported: 100rel,replaces</span><br><span style="color: hsl(120, 100%, 40%);">+ User-Agent: PolycomSoundPointIP-SPIP_430-UA/3.2.3.1734</span><br><span style="color: hsl(120, 100%, 40%);">+ Accept-Language: en</span><br><span style="color: hsl(120, 100%, 40%);">+ Content-Type: application/sdp</span><br><span style="color: hsl(120, 100%, 40%);">+ Content-Length: [len]</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ v=0</span><br><span style="color: hsl(120, 100%, 40%);">+ o=- 1324901698 1324901698 IN IP4 [local_ip]</span><br><span style="color: hsl(120, 100%, 40%);">+ s=Polycom IP Phone</span><br><span style="color: hsl(120, 100%, 40%);">+ c=IN IP4 [local_ip]</span><br><span style="color: hsl(120, 100%, 40%);">+ t=0 0</span><br><span style="color: hsl(120, 100%, 40%);">+ a=sendrecv</span><br><span style="color: hsl(120, 100%, 40%);">+ m=audio 2226 RTP/AVP 0 101</span><br><span style="color: hsl(120, 100%, 40%);">+ a=sendrecv</span><br><span style="color: hsl(120, 100%, 40%);">+ a=rtpmap:0 PCMU/8000</span><br><span style="color: hsl(120, 100%, 40%);">+ a=rtpmap:101 telephone-event/8000</span><br><span style="color: hsl(120, 100%, 40%);">+ ]]></span><br><span style="color: hsl(120, 100%, 40%);">+ </send></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ <recv request="ACK" next="wait_for_bye"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ <label id="scenario_end"/></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </scenario></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10901">change 10901</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10901"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia267cc138966dbd4449f2cab0fa56c01819a8c90 </div>
<div style="display:none"> Gerrit-Change-Number: 10901 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>