<p>Joshua C. Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10858">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua C. Colp: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip_sdp_rtp: Only enable abs-send-time when WebRTC is enabled.<br><br>For video streams it was possible for the abs-send-time information<br>to be placed into RTP streams even if not negotiated. Depending on<br>the endpoint in use this could cause video to not flow.<br><br>We now only enable abs-send-time for negotiation if WebRTC is enabled.<br><br>ASTERISK-28230<br><br>Change-Id: I0eb682302f8da3a4ea3c42e839208d55f825ed0c<br>---<br>M res/res_pjsip_sdp_rtp.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip_sdp_rtp.c b/res/res_pjsip_sdp_rtp.c</span><br><span>index 2889615..c18627e 100644</span><br><span>--- a/res/res_pjsip_sdp_rtp.c</span><br><span>+++ b/res/res_pjsip_sdp_rtp.c</span><br><span>@@ -272,7 +272,9 @@</span><br><span>                 ast_rtp_instance_set_prop(session_media->rtp, AST_RTP_PROPERTY_RETRANS_RECV, session->endpoint->media.webrtc);</span><br><span>              ast_rtp_instance_set_prop(session_media->rtp, AST_RTP_PROPERTY_RETRANS_SEND, session->endpoint->media.webrtc);</span><br><span>              ast_rtp_instance_set_prop(session_media->rtp, AST_RTP_PROPERTY_REMB, session->endpoint->media.webrtc);</span><br><span style="color: hsl(0, 100%, 40%);">-         enable_rtp_extension(session, session_media, AST_RTP_EXTENSION_ABS_SEND_TIME, AST_RTP_EXTENSION_DIRECTION_SENDRECV, sdp);</span><br><span style="color: hsl(120, 100%, 40%);">+             if (session->endpoint->media.webrtc) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  enable_rtp_extension(session, session_media, AST_RTP_EXTENSION_ABS_SEND_TIME, AST_RTP_EXTENSION_DIRECTION_SENDRECV, sdp);</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>            if (session->endpoint->media.tos_video || session->endpoint->media.cos_video) {</span><br><span>                  ast_rtp_instance_set_qos(session_media->rtp, session->endpoint->media.tos_video,</span><br><span>                                    session->endpoint->media.cos_video, "SIP RTP Video");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10858">change 10858</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10858"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0eb682302f8da3a4ea3c42e839208d55f825ed0c </div>
<div style="display:none"> Gerrit-Change-Number: 10858 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>