<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10859">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10859/1/include/asterisk/channel.h">File include/asterisk/channel.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10859/1/include/asterisk/channel.h@2601">Patch Set #1, Line 2601:</a> <code style="font-family:monospace,monospace">void ast_channel_internal_swap_endpoint_forward_and_endpoint_cache_forward(struct ast_channel *a, struct ast_channel *b);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Thank you Corey for your suggestion. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You're probably right.  If we're going to do anything about this it should probably be done against all the functions (not part of this commit).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10859/1/main/channel_internal_api.c">File main/channel_internal_api.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10859/1/main/channel_internal_api.c@1549">Patch Set #1, Line 1549:</a> <code style="font-family:monospace,monospace">void ast_channel_internal_swap_endpoint_forward_and_endpoint_cache_forward(struct ast_channel *a, struct ast_channel *b)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">IMO the conditionals in this function just makes it more difficult to read.  I feel it should be simplified as follows:</p><p style="white-space: pre-wrap; word-wrap: break-word;">```<br>struct stasis_forward *temp;</p><p style="white-space: pre-wrap; word-wrap: break-word;">temp = a->endpoint_forward;<br>a->endpoint_forward = b->endpoint_forward;<br>b->endpoint_forward = temp;</p><p style="white-space: pre-wrap; word-wrap: break-word;">temp = a->endpoint_cache_forward;<br>a->endpoint_cache_forward = b->endpoint_cache_forward;<br>b->endpoint_cache_forward = temp;<br>```</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10859">change 10859</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10859"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ied0451f378a3f2a36acc8c0984959a69895efa17 </div>
<div style="display:none"> Gerrit-Change-Number: 10859 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mohit Dhiman <mohitdhiman@drishti-soft.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Mohit Dhiman <mohitdhiman@drishti-soft.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 11 Jan 2019 13:30:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>