<p>Joshua C. Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10806">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua C. Colp: Looks good to me, but someone else must approve; Approved for Submit
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bridge_builtin_features.c: Set auto(mix)mon variables on both channels<br><br>This is how features behaved up through Asterisk 11, but was changed<br>when the new bridging framework was implemented in Asterisk 12.<br><br>Reported by rrittgarn in #asterisk.<br><br>Change-Id: I72cf86223947a8118c75f46e2c603dbc11e3125b<br>---<br>M CHANGES<br>M bridges/bridge_builtin_features.c<br>2 files changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/CHANGES b/CHANGES</span><br><span>index 5a68001..c9b8f5f 100644</span><br><span>--- a/CHANGES</span><br><span>+++ b/CHANGES</span><br><span>@@ -71,6 +71,19 @@</span><br><span>    ast_bridge_snapshot_update structure as it's data.  It contains</span><br><span>    the last snapshot and the new one.</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+Features</span><br><span style="color: hsl(120, 100%, 40%);">+------------------</span><br><span style="color: hsl(120, 100%, 40%);">+ * Before Asterisk 12, when using the automon or automixmon features defined</span><br><span style="color: hsl(120, 100%, 40%);">+   in features.conf, a channel variable (TOUCH_MIXMONITOR_OUTPUT) was set on</span><br><span style="color: hsl(120, 100%, 40%);">+   both channels, indicating the filename of the recording.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   When bridging was overhauled in Asterisk 12, the behavior was changed such</span><br><span style="color: hsl(120, 100%, 40%);">+   that the variable was only set on the peer channel and not on the channel</span><br><span style="color: hsl(120, 100%, 40%);">+   that initiated the automon or automixmon.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   The previous behavior has been restored so both channels receive the</span><br><span style="color: hsl(120, 100%, 40%);">+   channel variable when one of these features is invoked.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> ------------------------------------------------------------------------------</span><br><span> --- Functionality changes from Asterisk 16.0.0 to Asterisk 16.1.0 ------------</span><br><span> ------------------------------------------------------------------------------</span><br><span>diff --git a/bridges/bridge_builtin_features.c b/bridges/bridge_builtin_features.c</span><br><span>index e9efb91..671cfb9 100644</span><br><span>--- a/bridges/bridge_builtin_features.c</span><br><span>+++ b/bridges/bridge_builtin_features.c</span><br><span>@@ -213,6 +213,7 @@</span><br><span>               ast_bridge_channel_write_playfile(bridge_channel, NULL, start_message, NULL);</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ pbx_builtin_setvar_helper(bridge_channel->chan, "TOUCH_MONITOR_OUTPUT", touch_filename);</span><br><span>        pbx_builtin_setvar_helper(peer_chan, "TOUCH_MONITOR_OUTPUT", touch_filename);</span><br><span> }</span><br><span> </span><br><span>@@ -400,6 +401,7 @@</span><br><span>               ast_bridge_channel_write_playfile(bridge_channel, NULL, start_message, NULL);</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ pbx_builtin_setvar_helper(bridge_channel->chan, "TOUCH_MIXMONITOR_OUTPUT", touch_filename);</span><br><span>     pbx_builtin_setvar_helper(peer_chan, "TOUCH_MIXMONITOR_OUTPUT", touch_filename);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10806">change 10806</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10806"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I72cf86223947a8118c75f46e2c603dbc11e3125b </div>
<div style="display:none"> Gerrit-Change-Number: 10806 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>