<p><a href="https://gerrit.asterisk.org/10715">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10715/1/res/res_pjsip_sip_message.c">File res/res_pjsip_sip_message.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10715/1/res/res_pjsip_sip_message.c@68">Patch Set #1, Line 68:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static struct ast_sip_session_supplement supp_sip_in_req = {<br>              .priority = AST_SIP_SUPPLEMENT_PRIORITY_CHANNEL + 1,<br>          .incoming_request = incoming_request_handler,<br>};<br><br>static struct ast_sip_session_supplement supp_sip_in_res = {<br>             .priority = AST_SIP_SUPPLEMENT_PRIORITY_CHANNEL + 1,<br>          .incoming_response = incoming_response_handler,<br>};<br><br>static struct ast_sip_session_supplement supp_sip_out_req = {<br>          .priority = AST_SIP_SUPPLEMENT_PRIORITY_CHANNEL + 1,<br>          .outgoing_request = outgoing_request_handler,<br>};<br><br>static struct ast_sip_session_supplement supp_sip_out_res = {<br>            .priority = AST_SIP_SUPPLEMENT_PRIORITY_CHANNEL + 1,<br>          .outgoing_response = outgoing_response_handler,<br>};<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">incoming_request requires different type of return value. So, it's not possible to combine it. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">They can all still be in a single supplement, though. They don't need to be separate supplements.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10715">change 10715</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10715"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1 </div>
<div style="display:none"> Gerrit-Change-Number: 10715 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Nov 2018 22:21:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>