<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10663">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Corey Farrell: Looks good to me, but someone else must approve
Benjamin Keith Ford: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved
Jenkins2: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Testsuite: find out why chanspy test failed<br><br>This fixed a bug that caused the testsuite apps/chanspy to fail.<br>This was due to the following:<br>1- Adding parameter --no-tcp to pjsua. (Addressed in this review)<br>2- Building PJSUA with at least one codec (Addressed in another<br> review)<br><br>Change-Id: I937e4bfe185ffa7abac699e008de39c9e83e421d<br>---<br>M tests/apps/chanspy/chanspy_w_mixmonitor/run-test<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/apps/chanspy/chanspy_w_mixmonitor/run-test b/tests/apps/chanspy/chanspy_w_mixmonitor/run-test</span><br><span>index c70374f..39aafc7 100755</span><br><span>--- a/tests/apps/chanspy/chanspy_w_mixmonitor/run-test</span><br><span>+++ b/tests/apps/chanspy/chanspy_w_mixmonitor/run-test</span><br><span>@@ -118,9 +118,9 @@</span><br><span> def start_processes(self):</span><br><span> """Start up the PJSUA processes"""</span><br><span> LOGGER.info("Starting Processes")</span><br><span style="color: hsl(0, 100%, 40%);">- self.pja = subprocess.Popen(['pjsua', '--local-port=5065', '--auto-answer=200', '--null-audio'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</span><br><span style="color: hsl(0, 100%, 40%);">- self.pjb = subprocess.Popen(['pjsua', '--local-port=5066', '--auto-answer=200', '--null-audio'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</span><br><span style="color: hsl(0, 100%, 40%);">- self.pjc = subprocess.Popen(['pjsua', '--local-port=5067', '--auto-answer=200', '--null-audio'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</span><br><span style="color: hsl(120, 100%, 40%);">+ self.pja = subprocess.Popen(['pjsua', '--local-port=5065', '--auto-answer=200', '--null-audio', '--no-tcp'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</span><br><span style="color: hsl(120, 100%, 40%);">+ self.pjb = subprocess.Popen(['pjsua', '--local-port=5066', '--auto-answer=200', '--null-audio', '--no-tcp'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</span><br><span style="color: hsl(120, 100%, 40%);">+ self.pjc = subprocess.Popen(['pjsua', '--local-port=5067', '--auto-answer=200', '--null-audio', '--no-tcp'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</span><br><span> </span><br><span> def stop_processes(self):</span><br><span> """Stop said processes with prejudice"""</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10663">change 10663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10663"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I937e4bfe185ffa7abac699e008de39c9e83e421d </div>
<div style="display:none"> Gerrit-Change-Number: 10663 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>