<p style="white-space: pre-wrap; word-wrap: break-word;">I'll remove the -1 if I'm wrong, just want to make sure the comments are not missed.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10664">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10664/2/funcs/func_strings.c">File funcs/func_strings.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10664/2/funcs/func_strings.c@1113">Patch Set #2, Line 1113:</a> <code style="font-family:monospace,monospace">                        buf[strlen(buf) - 1] = ',';</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is it impossible for strlen(buf)==0 here?  What if a variable exists which matches the prefix only (nothing follows)?  I know completely off-nominal but this should defend against variables that were not created by the hash function.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe should check that ast_var_name(newvar) is longer than prefix and ends with '~' before writing to buf in the first place?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10664/2/funcs/func_strings.c@1144">Patch Set #2, Line 1144:</a> <code style="font-family:monospace,monospace">                      tmp[ast_str_strlen(*buf) - 1] = ',';</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10664">change 10664</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10664"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6e57fe7307dfd856271753aed5ba64c59b511487 </div>
<div style="display:none"> Gerrit-Change-Number: 10664 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 18 Nov 2018 18:21:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>